Page MenuHomePhabricator

Increase $mChangeLimit from 100 to 500 in AbuseFilterViewTestBatch.php (often not matching any filters currently)
Closed, DeclinedPublic

Description

The current value is too low to be useful. Most of the time I see no recent changes matching a given filter in the last 100 edits.


Version: master
Severity: normal
URL: https://github.com/wikimedia/mediawiki-extensions-AbuseFilter/blob/master/Views/AbuseFilterViewTestBatch.php#L5

Details

Reference
bz52968

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:53 AM
bzimport set Reference to bz52968.
bzimport added a subscriber: Unknown Object (MLST).

Change 82229 had a related patch set uploaded by Helder.wiki:
Increase $mChangeLimit from 100 to 500

https://gerrit.wikimedia.org/r/82229

Change 109461 had a related patch set uploaded by Arav93:
Increased $mChangeLimit from 100 to 500

https://gerrit.wikimedia.org/r/109461

Change 109461 abandoned by Hoo man:
Increased $mChangeLimit from 100 to 500

Reason:
Duplicate of: https://gerrit.wikimedia.org/r/82229

https://gerrit.wikimedia.org/r/109461

I don't think we can test (much) more than 100 changes here (performance wise) without running into timeouts or going out of memory. It's already possible to make this fail with 100 revisions, that's why I wouldn't allow more with the current state of the extension.

We have being using an AJAX workaround for the relevant part of this anyway...
https://github.com/he7d3r/mw-gadget-AbuseFilterRegressionTest

Change 82229 abandoned by Helder.wiki:
Increase $mChangeLimit from 100 to 500

Reason:
We have being using an AJAX workaround for the relevant part of this anyway...
https://pt.wikibooks.org/wiki/User:Helder.wiki/Tools/AbuseFilterRegressionTest.js

https://gerrit.wikimedia.org/r/82229