Page MenuHomePhabricator

Undo buffer can be fooled
Closed, DeclinedPublic

Description

Something terrible happened behind the scenes in VE, see bug 52982. When I tried to undo, the glitch-induced changes were not reverted, and it's possible that the undo algorithm was responsible for further damage to the document.

I would review how operations are being stored in the stack. Are there content checksums, or other error-checking measures such as absolute diff position? It might be feasible to store entire copies of the page content as savepoints.


Version: unspecified
Severity: normal

Details

Reference
bz52983

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:54 AM
bzimport added a project: VisualEditor.
bzimport set Reference to bz52983.

This is effectively "a fatal JS error means bad things for lots of the interface". Sadly something to avoid happening so this doesn't occur…