Page MenuHomePhabricator

LocalisationUpdate shell script uses a funky date output (Sun Aug 18 08:24:16 UTC 2013)
Closed, ResolvedPublic

Description

Inside operations/puppet.git, there's a shell script at files/misc/l10nupdate/l10nupdate-1 that runs LocalisationUpdate's ([[mw:Extension:LocalisationUpdate]]) update.php script and then logs to the server admin log ([[wikitech:SAL]]).

This shell script uses the output of date (presumably /bin/date), but date's default output is kind of stupid. Example:

$ date
Sun Aug 18 08:24:16 UTC 2013

The year comes after both the time and the time zone. This really doesn't make any sense. It'd be nice if date were passed an explicit format that was less stupid.


Version: wmf-deployment
Severity: minor

Details

Reference
bz52986

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:54 AM
bzimport set Reference to bz52986.

date --rfc-3339=seconds might be the easiest

(In reply to comment #2)

date --rfc-3339=seconds might be the easiest

Not sure if this was intended as a joke, but my version of BSD date doesn't have this flag. I looked up RFC 3339. I assume you mean [[ISO 8601]]. I think that format would be fine to resolve this bug.

(In reply to comment #1)

Any recommendation?

ISO 8601 format as Nemo suggests in comment 2 would be fine. Or the equivalent of "~~~~~" expanded; MediaWiki's format is easy enough to read. :-)

(In reply to comment #3)

(In reply to comment #2)

date --rfc-3339=seconds might be the easiest

Not sure if this was intended as a joke, but my version of BSD date doesn't
have this flag. I looked up RFC 3339. I assume you mean [[ISO 8601]]. I think
that format would be fine to resolve this bug.

No, it's not a joke; date (GNU coreutils) 8.17.
$ date --rfc-3339=seconds
2013-08-27 11:20:33+02:00

(In reply to comment #1)

Any recommendation?

ISO 8601 format as Nemo suggests in comment 2 would be fine.

It's just a bit uglier. :)
$ date --iso-8601=seconds
2013-08-27T11:23:31+0200

Change 106892 had a related patch set uploaded by Tinaj1234:
Changed date format in l10nupdate-1

https://gerrit.wikimedia.org/r/106892

Change 106892 merged by Alexandros Kosiaris:
Changed date format in l10nupdate-1

https://gerrit.wikimedia.org/r/106892

(In reply to comment #2)

date --rfc-3339=seconds might be the easiest

Oh, I forgot that was my suggestion. Anyway, merged; given the number of +1 I declare this fixed by popular vote.