Page MenuHomePhabricator

Mobile rendering improperly omits space after reference and before wikilink
Closed, ResolvedPublic

Description

Author: macmog

Description:
Screenshots showing all three rendered examples in desktop Safari

  1. On the mobile site http://en.m.wikipedia.org/, view a page with a reference tag immediately before a Wikilink. Note that the tag does not have a space between the reference callout number and the following Wikilink.
  2. View the same page on the desktop site http://en.wikipedia.org/wiki/ and note that the same tag _does_ have a space between the reference callout number and the following Wikilink.
  3. Edit the page, find the tag in question, and confirm that the source does have the space.

Examples:
http://en.m.wikipedia.org/wiki/Dads, under heading "Development and production", subheading "Casting":
whose father Crawford moves in with him.[7]Peter Riegert was then added
Edna, Eli's hard-drinking, outspoken maid.[10]Seth Green and Erin Pineda

http://en.wikipedia.org/wiki/Dads:
whose father Crawford moves in with him.[7] Peter Riegert was then added
Edna, Eli's hard-drinking, outspoken maid.[10] Seth Green and Erin Pineda

http://en.m.wikipedia.org/wiki/Clare_Grant, under heading "Career", subheading "Television work":
She does voices on Robot Chicken,[1]MAD & originated a bounty hunter

http://en.wikipedia.org/wiki/Clare_Grant
She does voices on Robot Chicken,[1] MAD & originated a bounty hunter

http://en.m.wikipedia.org/wiki/Husbands_(sitcom), under heading "Production", subheading "Casting":
Amber Benson, Emma Caulfield,[16]Tricia Helfer, Sasha Roiz,
Aasha Davis, Clare Grant,[17]Jon Cryer and Mekhi Phifer.

http://en.wikipedia.org/wiki/Husbands_(sitcom)
Amber Benson, Emma Caulfield,[16] Tricia Helfer, Sasha Roiz,
Aasha Davis, Clare Grant,[17] Jon Cryer and Mekhi Phifer.

See attached screenshot for rendered examples in desktop Safari.

Tested with a recent version of Mobile Safari, desktop Safari 6.0.5 (8536.30.1), and Firefox 17.0.8 (OS X). All exhibit the same behavior.


Version: unspecified
Severity: minor

Attached:

Mobile_rendering_improperly_omits_space_screenshot.png (957×817 px, 767 KB)

Details

Reference
bz53086

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:01 AM
bzimport set Reference to bz53086.

Thanks for taking the time to report this!
Confirming on http://en.m.wikipedia.org/wiki/Dads with Firefox 23.

Mmm.. it seems that the wikitext has a space between the link and the reference - is this an issue with the parser? The references look fine when they are not followed by a link.

Adding styling to the reference itself would result in a larger space when a link doesn't follow. Andre - who's best to comment on whether this is a parser bug and not a MobileFrontend one?

Really confused why this doesn't effect desktop. Maybe something to do with our formatter hacks?

ie. use of DOMParse.. ? Max any thoughts..?

  • Bug 53418 has been marked as a duplicate of this bug. ***

Change 81507 had a related patch set uploaded by MaxSem:
Fix spaces after references

https://gerrit.wikimedia.org/r/81507

Change 81507 merged by jenkins-bot:
Fix spaces after references

https://gerrit.wikimedia.org/r/81507

  • Bug 54171 has been marked as a duplicate of this bug. ***