Echo notifications icons (in p-personal) displayed with missing or incorrect style after a CentralAuth autologin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ltrlg
	Aug 20 2013, 11:19 PM

Description

Steps to reproduce

Create an account
Log in to en.wikipedia.org. Might need to select "keep me logged in" type settings to set the central auth cookies on loginwiki.
Visit a wiki on a different second-level domain, such as en.wikiquote.org.

What happens?:

Ping and notice icons are replaced with text like Alert (0). Sometimes the icon styling is missing:

sometimes it is repeated:

A page refresh fixes the issue.

What should have happened instead?:

Ping and notice icons are normal on first page load. No refresh needed.

Other information

HTML looks identical.

Possible CSS issue. The following appears to be present in the working example and missing in the non working example.

Caused by CentralAuth autologin (sometimes) replacing the user toolbar without reloading the page, see modules/inline/autologin.js
That script calls the centralauth-p-personal-reset JS hook, which is probably the right place to fix this

Details

Reference: bz53134

	Subject	Repo	Branch	Lines +/-
	Initialize Echo when CentralAuth autologin replaces the user toolbar	mediawiki/extensions/Echo	master	+23 -0

Customize query in gerrit

Related Objects

Mentioned In: W2269 Echo Tasks

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM

• bzimport added a project: MediaWiki-extensions-CentralAuth.

• bzimport set Reference to bz53134.

• bzimport added a subscriber: Unknown Object (MLST).

Ltrlg created this task.Aug 20 2013, 11:19 PM

That's a CA issue.

Bug 55545 has been marked as a duplicate of this bug. ***

I think Echo just needs to add a listener to the centralauth-p-personal-reset hook?

• werdna unsubscribed.Dec 10 2014, 5:24 PM

matej_suchanek added projects: Notifications, TestMe.Jul 8 2016, 8:09 PM

matej_suchanek removed a subscriber: • wikibugs-l-list.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 8 2016, 8:09 PM

-TestMe, I see this pretty often.

• Mattflaschen-WMF added a project: Collaboration-Team-Triage.Aug 5 2016, 7:08 PM

SBisson mentioned this in W2269 Echo Tasks.Apr 17 2019, 3:10 PM

SBisson merged a task: T123160: Echo counter styling broken after CentralAuth autologin.Apr 19 2019, 8:02 PM

SBisson added subscribers: Tgr, Prod, • Mattflaschen-WMF and 2 others.

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 19 2019, 8:02 PM

Prod unsubscribed.Dec 6 2020, 8:12 AM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM

Krinkle unsubscribed.Apr 15 2021, 8:19 PM

Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:10 PM

Tgr renamed this task from Echo / SUL: Notifications number displayed without style (in p-personal) on first time to Echo notifications icons (in p-personal) displayed with missing or incorrect style after a CentralAuth autologin.Nov 16 2022, 3:15 AM

Tgr merged a task: T323189: Malformed Echo alert and message icons on first visit to a wiki when using CentralAuth autologin.

Tgr added a subscriber: Novem_Linguae.

Tgr updated the task description. (Show Details)Nov 16 2022, 3:24 AM

Tgr attached a referenced file: F35784189: image.png. (Show Details)Nov 16 2022, 3:28 AM

Tgr attached a referenced file: F35784192: image.png. (Show Details)

Tgr attached a referenced file: F35784182: image.png. (Show Details)

Tgr attached a referenced file: F35784175: image.png. (Show Details)

In T55134#577962, @Legoktm wrote:

I think Echo just needs to add a listener to the centralauth-p-personal-reset hook?

Yeah I think we'd have to redo some of ext.echo.init.js when that hook is called.

Change 858697 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/Echo@master] Initialize Echo when CentralAuth autologin replaces the user toolbar

https://gerrit.wikimedia.org/r/858697

gerritbot added a project: Patch-For-Review.Nov 20 2022, 7:28 AM

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team-Filtering, Growth-Team.Nov 20 2022, 9:21 PM

Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 21 2022, 8:47 AM

Change 858697 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Initialize Echo when CentralAuth autologin replaces the user toolbar

https://gerrit.wikimedia.org/r/858697

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2022, 9:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 21 2022, 10:01 AM

Etonkovidova awarded a token.Jan 10 2023, 1:21 AM

Checked on wmf.17 - works as expected.

	F11729: SUL-Echo.png
	Nov 16 2022, 3:16 AM

Echo notifications icons (in p-personal) displayed with missing or incorrect style after a CentralAuth autologinClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Echo notifications icons (in p-personal) displayed with missing or incorrect style after a CentralAuth autologin
Closed, ResolvedPublic
Actions