Page MenuHomePhabricator

VisualEditor: Annotating an inline alien breaks node protection
Closed, ResolvedPublic

Description

  1. Create a document with: Foo <cite>Alien</cite> Bar
  2. Select all and bold

Results

  1. 'Alien' is bolded, despite being protected (questionable)
  2. The shield has disappeared.

Version: unspecified
Severity: normal

Details

Reference
bz53149

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:05 AM
bzimport set Reference to bz53149.
matmarex subscribed.

This seems to behave correctly these days.

  1. It is still bolded, but I think that's usually the right behavior. (We could change this by using blacklistedAnnotationTypes, which we use now mostly to disallow applying link annotations over nodes that already contain links.)
  2. This doesn't happen, the "shield" is still present and catches clicks. (I believe that's the same thing that we call "highlights" now, the striped overlay thing?)
    image.png (2×3 px, 382 KB)