Page MenuHomePhabricator

Language links not correctly marked as "mw:WikiLink/Language" by Parsoid
Closed, ResolvedPublic

Description

(Bug coming from #51430 comment)

As far as I can see, these links are not marked "mw:WikiLink/Language" but
simply "mw:WikiLink". So, it's not possible to make any difference between them and "normal" wikilinks.

See a the end of this page for example:
http://parsoid.wmflabs.org/ko/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8


Version: unspecified
Severity: normal

Details

Reference
bz53243

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:12 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz53243.

The reason might be that those are marked as "local" in the interwiki info returned from the API. That means that there is a redirect configured from http://en.wikipedia.org/wiki/ko: to http://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8.

We should still mark them as language links as that is the way they are interpreted by the PHP parser. Pointing the href to the absolute URL ending in /wiki/ should also be fine as that redirects to the wiki's main page just as the local redirect does.

Change 81413 had a related patch set uploaded by GWicke:
Bug 53243: Accept prefix-only interwiki / language links

https://gerrit.wikimedia.org/r/81413

See bug 53432 for a related serializer bug uncovered by the tests added in the patch above.

Change 81413 merged by jenkins-bot:
Bug 53243: Accept prefix-only interwiki / language links

https://gerrit.wikimedia.org/r/81413

Now deployed in production.

Note that we are planning to rename some of these typeofs. mw:WikiLink/Language will likely become mw:PageProp/Language. See https://bugzilla.wikimedia.org/show_bug.cgi?id=53432 for the details, and let us know if you see issues for Kiwix.

THX. As long as I can identify the language links, this is good to me; whatever how this is labelled.