There's a lot of jQuery use in UW, but a lot of it seems like it was thrown in before we have our current best-practices guidelines for its use, and really doesn't follow them. Probably something it would be good to look into.
Version: master
Severity: minor
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T51987 UploadWizard has some pretty awful code in places (tracking) | |||
| Resolved | MarkTraceur | T55245 Audit jQuery use in UploadWizard |
Change 86803 had a related patch set uploaded by MarkTraceur:
jquery audit of mw.ApiUploadHandler.js
Change 86804 had a related patch set uploaded by MarkTraceur:
jquery audit of mw.DestinationChecker.js
Change 86805 had a related patch set uploaded by MarkTraceur:
jquery audit of mw.ErrorDialog.js
Change 86810 had a related patch set uploaded by MarkTraceur:
jquery audit of mw.GroupProgressBar.js
Change 86811 had a related patch set uploaded by MarkTraceur:
jquery audit on mw.IframeTransport.js
Change 86814 had a related patch set uploaded by MarkTraceur:
jquery audit and code convention fixes for mw.UWUI
Change 87885 had a related patch set uploaded by MarkTraceur:
jquery audit for mw.LanguageUpWiz.js
Change 88124 had a related patch set uploaded by MarkTraceur:
jquery audit for mw.UploadWizard.js
Change 88476 had a related patch set uploaded by Alex Monk:
Fix a few remaining things in mw.LanguageUpWiz.js
Change 88476 merged by jenkins-bot:
Fix a few remaining things in mw.LanguageUpWiz.js
Change 141191 had a related patch set uploaded by Inchikutty:
jquery audit on mw.IframeTransport.js
Current status: All pending patches abandoned, anticipating that we will fix this as we migrate to OOUI.
@MarkTraceur Can you recall what criteria were you using in your audit, and give the files a look and see it they now meet them? We weren't working on this specifically, but looking at the commit messages above, many of the files no longer exist at all (mw.IframeTransport.js) or were completely rewritten (mw.LanguageUpWiz.js, mw.ErrorDialog.js).
Yes, sorry about that @matmarex!
As I recall, most of this was using DOM building shortcuts (i.e. $( '<div>' )) instead of parsing big HTML strings while building the interface. I think the issues have been addressed to my satisfaction.