Page MenuHomePhabricator
Create Task
Maniphest T55261

Edit tutorial persists after logging out
Closed, ResolvedPublic
Actions

Description

Author: jgonera

Description:

  1. Go to a page and click the main edit button.
  2. Log in using the CTA link.
  3. Click cancel in the tutorial.
  4. Log out and click the "Return to page_name" link.
  5. You're back on the page, logged out and with the tutorial visible.

Version: unspecified
Severity: normal

Details

Reference
bz53261

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:13 AM
• bzimport added a project: MobileFrontend-beta.
• bzimport set Reference to bz53261.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Aug 23 2013, 5:29 PM
Jdlrobson added a comment.Aug 23 2013, 5:46 PM

It will do since the login/logout urls pass all existing query string parameters. We probably want to whitelist the ones that we need...

• bzimport added a comment.Aug 23 2013, 6:08 PM

jgonera wrote:

Or you can simply not run the whole tutorial code if the user is logged out.

Jdlrobson added a comment.Aug 23 2013, 6:31 PM

That's true :)

gerritbot added a comment.Sep 4 2013, 11:14 PM

Change 82764 had a related patch set uploaded by JGonera:
Don't show newbie tutorials after logging out

https://gerrit.wikimedia.org/r/82764

gerritbot added a comment.Sep 6 2013, 7:14 PM

Change 82764 merged by jenkins-bot:
Don't show newbie tutorials after logging out

https://gerrit.wikimedia.org/r/82764

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL