Page MenuHomePhabricator

Improve Error handling of GeoLocation api
Closed, ResolvedPublic

Description

Currently the code simply prints an error. This error however doesn't take into account the cause of the geolocation failure. I was getting messages that my signal wasn't good, but the true reason was that I had simply disable all Safari location permissions. I was genuinely confused.

So in the nearby.js error handler, pass the error to the error handler and print appropriate messages depending on the cause of the failure:

https://developer.mozilla.org/en-US/docs/Web/API/PositionError


Version: unspecified
Severity: enhancement

Details

Reference
bz53342

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:49 AM
bzimport set Reference to bz53342.
bzimport added a subscriber: Unknown Object (MLST).

Yeh this would be a good idea. Our error handling is currently a little lazy.

Change 84459 had a related patch set uploaded by Jdlrobson:
Improve nearby error handling

https://gerrit.wikimedia.org/r/84459

Change 84459 merged by jenkins-bot:
Improve nearby error handling

https://gerrit.wikimedia.org/r/84459