Page MenuHomePhabricator

migrate all .pep8 files content to setup.cfg / tox.ini
Closed, DeclinedPublic

Description

pep8 1.4 now supports reading configuration parameters from a 'pep8' section in tox.ini. That would let us get rid of the .pep8 files in the repositories and have all the tools configured in a single file.

Details

Reference
bz53353

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:50 AM
bzimport set Reference to bz53353.
bzimport added a subscriber: Unknown Object (MLST).

pep8 v1.4.5 has been deployed on the slaves (was bug 53352)

From a discussion we had with Bryan Davis, the flake8/pep8 configuration should be in setup.cfg.

(In reply to Antoine "hashar" Musso from comment #2)

From a discussion we had with Bryan Davis, the flake8/pep8 configuration
should be in setup.cfg.

It was my understanding that flake8 and pep8 will not consider setup.cfg if there is a tox.ini file. Or will they?

(In reply to Jean-Fred from comment #3)

It was my understanding that flake8 and pep8 will not consider setup.cfg if
there is a tox.ini file. Or will they?

Was apparently a bug in pep8 which got fixed with pep8 1.4.6. From its change log at https://pypi.python.org/pypi/pep8:


When both a tox.ini and a setup.cfg are present in the project directory, merge their contents. The tox.ini file takes precedence (same as before). (Issue #182)

hashar renamed this task from migrate all .pep8 files content to setup.cfg to migrate all .pep8 files content to setup.cfg / tox.ini.Sep 30 2015, 9:23 AM
hashar updated the task description. (Show Details)
hashar set Security to None.
hashar claimed this task.

We are moving to tox/flake8 so most repos have the configuration done either in setup.cfg or tox.ini.