Page MenuHomePhabricator
Create Task
Maniphest T55354

JJB: replace pyflakes / pep8 jobs with tox-jessie job
Closed, ResolvedPublic
Actions

Description

flake8 is a wrapper around several tools (among them pep8 and flake8). Having a single job to run all the python quality tools will save up a bit of processing time and a few jobs.

Since flake8 does not support reading pep8 configuration from a .pep8 file, we need to migrate all .pep8 content to a tox.ini file which is bug 53353.

Details

Reference
bz53354
SubjectRepoBranchLines +/-
tox integration to run flake8operations/dumpsariel+69 -0
tox integration to run flake8operations/dumpsmaster+26 -0
Remove pyflakes/pep8 jobsintegration/configmaster+9 -87
Unconfigure fundraising pyflakes/pep8 jobsintegration/configmaster+6 -35
Unconfigure mediawiki/tools/fluorideintegration/configmaster+0 -11
Drop Jenkins jobs for analytics-glassintegration/configmaster+0 -7
Drop operations/dumps pyflakes/pep8 jobsintegration/configmaster+4 -12
[SemanticResultFormats] Drop pyflakes/pep8 jobsintegration/configmaster+0 -5
tox entry point to run pep8 1.4.6pywikibot/compatmaster+13 -4
Migrate pywikibot/compat to tox-jessieintegration/configmaster+4 -11
[SemanticBundle] Drop pyflakes/pep8integration/configmaster+0 -12
tox entry point to run python lintersmediawiki/extensions/Offlinemaster+13 -1
[Offline] Replace pep8/pyflakes with toxintegration/configmaster+8 -14
Drop mwext-DumpHTML-{pep8,pyflakes}integration/configmaster+0 -12
Drop pywikibot-bots-CommonsDelinker-tox-flake8integration/configmaster+0 -15
Drop mwext-ConfirmEdit-{pep8,pyflakes}integration/configmaster+0 -18
Drop mw-tools-codeutils-{pep8,pyflakes}integration/configmaster+0 -11
Switch labs/migration-assistant to toxintegration/configmaster+4 -10
Drop operations-debs-ircecho-{pep8,pyflakes}integration/configmaster+0 -10
Drop pywikibot-i18n-{pep8,pyflakes}integration/configmaster+0 -12
Archive mediawiki/extensions/BlameMapsintegration/configmaster+2 -25
[OpenStackManager] remove pep8/pyflakes jobsintegration/configmaster+0 -18
Migrate ops/debs/adminbot to tox/flake8integration/configmaster+4 -8
Remove pep8/pyflakes for mw/tools/scapintegration/configmaster+0 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
hashar added a project: Essential-Work.Sep 11 2015, 10:51 AM
gerritbot added a comment.Sep 21 2015, 8:35 PM

Change 237492 merged by jenkins-bot:
Migrate ops/debs/adminbot to tox/flake8

https://gerrit.wikimedia.org/r/237492

gerritbot added a comment.Sep 21 2015, 8:35 PM

Change 237617 merged by jenkins-bot:
Remove pep8/pyflakes for mw/tools/scap

https://gerrit.wikimedia.org/r/237617

hashar mentioned this in rCICF3f6d3847f609: Migrate ops/debs/adminbot to tox/flake8.Sep 21 2015, 8:35 PM
hashar mentioned this in rCICF82153d8360e1: Remove pep8/pyflakes for mw/tools/scap.
gerritbot added a comment.Sep 27 2015, 7:02 PM

Change 241558 had a related patch set uploaded (by Hashar):
[OpenStackManager] remove pep8/pyflakes jobs

https://gerrit.wikimedia.org/r/241558

gerritbot added a comment.Sep 27 2015, 7:06 PM

Change 241558 merged by jenkins-bot:
[OpenStackManager] remove pep8/pyflakes jobs

https://gerrit.wikimedia.org/r/241558

hashar mentioned this in rCICF474177cf1b42: [OpenStackManager] remove pep8/pyflakes jobs.Sep 27 2015, 7:06 PM
gerritbot added a comment.Sep 28 2015, 12:14 PM

Change 241639 had a related patch set uploaded (by Hashar):
Archive mediawiki/extensions/BlameMaps

https://gerrit.wikimedia.org/r/241639

gerritbot added a comment.Sep 28 2015, 1:05 PM

Change 241639 merged by jenkins-bot:
Archive mediawiki/extensions/BlameMaps

https://gerrit.wikimedia.org/r/241639

hashar mentioned this in rCICF695a26d3ad63: Archive mediawiki/extensions/BlameMaps.Sep 28 2015, 1:05 PM
gerritbot added a comment.Sep 30 2015, 9:04 AM

Change 242494 had a related patch set uploaded (by Hashar):
tox integration to run flake8

https://gerrit.wikimedia.org/r/242494

hashar added a subtask: T114218: wikimedia/fundraising/tools should pass python lint checks (flake8).Sep 30 2015, 9:24 AM
hashar renamed this task from JJB: replace pyflakes / pep8 jobs with flake8 jobs to JJB: replace pyflakes / pep8 jobs with fox-jessie job.Sep 30 2015, 1:45 PM
hashar updated the task description. (Show Details)
hashar set Security to None.
gerritbot added a comment.Sep 30 2015, 1:49 PM

Change 242545 had a related patch set uploaded (by Hashar):
Drop pywikibot-i18n-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242545

gerritbot added a comment.Sep 30 2015, 1:54 PM

Change 242545 merged by jenkins-bot:
Drop pywikibot-i18n-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242545

hashar mentioned this in rCICF80996563022f: Drop pywikibot-i18n-{pep8,pyflakes}.Sep 30 2015, 1:55 PM
gerritbot added a comment.Sep 30 2015, 2:00 PM

Change 242547 had a related patch set uploaded (by Hashar):
Drop operations-debs-ircecho-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242547

gerritbot added a comment.Sep 30 2015, 2:02 PM

Change 242547 merged by jenkins-bot:
Drop operations-debs-ircecho-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242547

hashar mentioned this in rCICF43d44c31c171: Drop operations-debs-ircecho-{pep8,pyflakes}.Sep 30 2015, 2:02 PM
gerritbot added a comment.Sep 30 2015, 2:07 PM

Change 242552 had a related patch set uploaded (by Hashar):
Switch labs/migration-assistant to tox

https://gerrit.wikimedia.org/r/242552

gerritbot added a comment.Sep 30 2015, 2:12 PM

Change 242552 merged by jenkins-bot:
Switch labs/migration-assistant to tox

https://gerrit.wikimedia.org/r/242552

hashar mentioned this in rCICFfb93988a0fe4: Switch labs/migration-assistant to tox.Sep 30 2015, 2:13 PM
gerritbot added a comment.Sep 30 2015, 2:21 PM

Change 242557 had a related patch set uploaded (by Hashar):
Drop mw-tools-codeutils-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242557

gerritbot added a comment.Sep 30 2015, 2:23 PM

Change 242557 merged by jenkins-bot:
Drop mw-tools-codeutils-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242557

hashar mentioned this in rCICF29ec05ab8a1e: Drop mw-tools-codeutils-{pep8,pyflakes}.Sep 30 2015, 2:23 PM
gerritbot added a comment.Sep 30 2015, 2:29 PM

Change 242560 had a related patch set uploaded (by Hashar):
Drop mwext-ConfirmEdit-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242560

gerritbot added a comment.Sep 30 2015, 2:34 PM

Change 242560 merged by jenkins-bot:
Drop mwext-ConfirmEdit-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242560

hashar mentioned this in rCICF1cc7c9270ed4: Drop mwext-ConfirmEdit-{pep8,pyflakes}.Sep 30 2015, 2:34 PM
gerritbot added a comment.Sep 30 2015, 2:34 PM

Change 242564 had a related patch set uploaded (by Hashar):
Drop pywikibot-bots-CommonsDelinker-tox-flake8

https://gerrit.wikimedia.org/r/242564

gerritbot added a comment.Sep 30 2015, 2:36 PM

Change 242564 merged by jenkins-bot:
Drop pywikibot-bots-CommonsDelinker-tox-flake8

https://gerrit.wikimedia.org/r/242564

hashar mentioned this in rCICFd85b0405599e: Drop pywikibot-bots-CommonsDelinker-tox-flake8.Sep 30 2015, 2:37 PM
gerritbot added a comment.Sep 30 2015, 2:38 PM

Change 242568 had a related patch set uploaded (by Hashar):
Drop mwext-DumpHTML-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242568

hashar mentioned this in T114249: operations/dumps repo should pass flake8.Sep 30 2015, 2:40 PM
gerritbot added a comment.Sep 30 2015, 2:40 PM

Change 242568 merged by jenkins-bot:
Drop mwext-DumpHTML-{pep8,pyflakes}

https://gerrit.wikimedia.org/r/242568

hashar mentioned this in rCICF3926235ce129: Drop mwext-DumpHTML-{pep8,pyflakes}.Sep 30 2015, 2:41 PM
hashar mentioned this in T114250: Switch wikimedia/fundraising/slander to use tox as an entry point.Sep 30 2015, 2:53 PM
hashar closed subtask T55353: migrate all .pep8 files content to setup.cfg / tox.ini as Declined.Oct 1 2015, 11:35 AM
gerritbot added a comment.Oct 1 2015, 11:46 AM

Change 242858 had a related patch set uploaded (by Hashar):
tox entry point to run python linters

https://gerrit.wikimedia.org/r/242858

gerritbot added a comment.Oct 1 2015, 11:48 AM

Change 242859 had a related patch set uploaded (by Hashar):
[Offline] Replace pep8/pyflakes with tox

https://gerrit.wikimedia.org/r/242859

gerritbot added a comment.Oct 1 2015, 11:51 AM

Change 242859 merged by jenkins-bot:
[Offline] Replace pep8/pyflakes with tox

https://gerrit.wikimedia.org/r/242859

hashar mentioned this in rCICF8b3e8bdfd5d1: [Offline] Replace pep8/pyflakes with tox.Oct 1 2015, 11:51 AM
gerritbot added a comment.Oct 1 2015, 11:52 AM

Change 242858 merged by jenkins-bot:
tox entry point to run python linters

https://gerrit.wikimedia.org/r/242858

hashar mentioned this in rMEXT778117d5ce7c: Updated mediawiki/extensions Project: mediawiki/extensions/Offline….Oct 1 2015, 11:53 AM
gerritbot added a comment.Oct 1 2015, 11:55 AM

Change 242861 had a related patch set uploaded (by Hashar):
[SemanticBundle] Drop pyflakes/pep8

https://gerrit.wikimedia.org/r/242861

hashar mentioned this in rEOFF46dbf80b8664: tox entry point to run python linters.Oct 1 2015, 11:56 AM
gerritbot added a comment.Oct 1 2015, 11:59 AM

Change 242861 merged by jenkins-bot:
[SemanticBundle] Drop pyflakes/pep8

https://gerrit.wikimedia.org/r/242861

hashar mentioned this in rCICFe1ac6378b1a1: [SemanticBundle] Drop pyflakes/pep8.Oct 1 2015, 12:00 PM
gerritbot added a comment.Oct 1 2015, 12:08 PM

Change 242864 had a related patch set uploaded (by Hashar):
tox entry point to run pep8 1.4.6

https://gerrit.wikimedia.org/r/242864

gerritbot added a comment.Oct 1 2015, 12:11 PM

Change 242865 had a related patch set uploaded (by Hashar):
Migrate pywikibot/compat to tox-jessie

https://gerrit.wikimedia.org/r/242865

gerritbot added a comment.Oct 1 2015, 12:15 PM

Change 242865 merged by jenkins-bot:
Migrate pywikibot/compat to tox-jessie

https://gerrit.wikimedia.org/r/242865

hashar mentioned this in rCICF703d107a6189: Migrate pywikibot/compat to tox-jessie.Oct 1 2015, 12:17 PM
gerritbot added a comment.Oct 1 2015, 12:26 PM

Change 242864 merged by jenkins-bot:
tox entry point to run pep8 1.4.6

https://gerrit.wikimedia.org/r/242864

hashar mentioned this in rPWBO622614203990: tox entry point to run pep8 1.4.6.Oct 1 2015, 12:26 PM
gerritbot added a comment.Oct 1 2015, 12:41 PM

Change 242872 had a related patch set uploaded (by Hashar):
[SemanticResultFormats] Drop pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242872

hashar claimed this task.Oct 1 2015, 12:43 PM
hashar mentioned this in T114360: Remove packages pep8 / pylint and pyflakes from CI slaves.
hashar added a parent task: T114360: Remove packages pep8 / pylint and pyflakes from CI slaves.
hashar edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure.
hashar moved this task from Backlog to In progress on the Continuous-Integration-Config board.
gerritbot added a comment.Oct 1 2015, 12:44 PM

Change 242872 merged by jenkins-bot:
[SemanticResultFormats] Drop pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242872

hashar mentioned this in rCICF6d4d3cf76219: [SemanticResultFormats] Drop pyflakes/pep8 jobs.Oct 1 2015, 12:46 PM
gerritbot added a comment.Oct 1 2015, 12:49 PM

Change 242873 had a related patch set uploaded (by Hashar):
Drop operations/dumps pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242873

gerritbot added a comment.Oct 1 2015, 12:52 PM

Change 242873 merged by jenkins-bot:
Drop operations/dumps pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242873

hashar mentioned this in rCICFd73ad0c421ba: Drop operations/dumps pyflakes/pep8 jobs.Oct 1 2015, 12:54 PM
gerritbot added a comment.Oct 1 2015, 1:02 PM

Change 242878 had a related patch set uploaded (by Hashar):
Drop Jenkins jobs for analytics-glass

https://gerrit.wikimedia.org/r/242878

gerritbot added a comment.Oct 1 2015, 1:05 PM

Change 242879 had a related patch set uploaded (by Hashar):
Unconfigure mediawiki/tools/fluoride

https://gerrit.wikimedia.org/r/242879

gerritbot added a comment.Oct 1 2015, 1:05 PM

Change 242878 merged by jenkins-bot:
Drop Jenkins jobs for analytics-glass

https://gerrit.wikimedia.org/r/242878

hashar mentioned this in rCICF7ca233465920: Drop Jenkins jobs for analytics-glass.Oct 1 2015, 1:06 PM
gerritbot added a comment.Oct 1 2015, 1:07 PM

Change 242879 merged by jenkins-bot:
Unconfigure mediawiki/tools/fluoride

https://gerrit.wikimedia.org/r/242879

hashar removed a subtask: T114249: operations/dumps repo should pass flake8.Oct 1 2015, 1:08 PM
hashar mentioned this in rCICF71169b45d787: Unconfigure mediawiki/tools/fluoride.Oct 1 2015, 1:08 PM
hashar mentioned this in T114361: Switch wikimedia/fundraising/SmashPig to use tox as an entry point.Oct 1 2015, 1:11 PM

We are down to three repositories still using the pyflakes/pep8 pair of jobs:

Repo Task
wikimedia/fundraising/SmashPigT114361
wikimedia/fundraising/slanderT114250
wikimedia/fundraising/toolsT114218
hashar added a subtask: T114361: Switch wikimedia/fundraising/SmashPig to use tox as an entry point.Oct 1 2015, 1:12 PM
gerritbot added a comment.Oct 1 2015, 1:21 PM

Change 242882 had a related patch set uploaded (by Hashar):
Unconfigure fundraising pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242882

gerritbot added a comment.Oct 1 2015, 1:24 PM

Change 242882 merged by jenkins-bot:
Unconfigure fundraising pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242882

hashar mentioned this in rCICFf901f096b5fb: Unconfigure fundraising pyflakes/pep8 jobs.Oct 1 2015, 1:24 PM
hashar removed subtasks: T114361: Switch wikimedia/fundraising/SmashPig to use tox as an entry point, T114250: Switch wikimedia/fundraising/slander to use tox as an entry point, T114218: wikimedia/fundraising/tools should pass python lint checks (flake8).Oct 1 2015, 1:31 PM
gerritbot added a comment.Oct 1 2015, 1:37 PM

Change 242885 had a related patch set uploaded (by Hashar):
Remove pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242885

gerritbot added a comment.Oct 1 2015, 1:39 PM

Change 242885 merged by jenkins-bot:
Remove pyflakes/pep8 jobs

https://gerrit.wikimedia.org/r/242885

hashar closed this task as Resolved.Oct 1 2015, 1:39 PM

I have deleted all pep8 / pyflakes jobs but operations-puppet-pep8.

The fundraising jobs have been unconfigured and tasks filled to have them switch to tox.

The CI configuration has been cleaned up.

hashar mentioned this in rCICFb0ba11cb29c0: Remove pyflakes/pep8 jobs.Oct 1 2015, 1:42 PM
hashar mentioned this in rWFTO6a09b09bbf2d: tox integration to run the flake8 linter.Oct 1 2015, 6:22 PM
hashar moved this task from In progress to Archive on the Continuous-Integration-Config board.Oct 6 2015, 11:19 AM
Paladox renamed this task from JJB: replace pyflakes / pep8 jobs with fox-jessie job to JJB: replace pyflakes / pep8 jobs with tox-jessie job.Oct 16 2015, 3:22 PM
Paladox removed a project: Patch-For-Review.
Paladox removed a subscriber: gerritbot.
Ricordisamoa subscribed.Jan 4 2016, 4:23 AM
gerritbot added a comment.Jan 5 2016, 11:00 AM

Change 242494 abandoned by Hashar:
tox integration to run flake8

https://gerrit.wikimedia.org/r/242494

hashar mentioned this in T125363: Tests are not run on a change in operations/software.Feb 17 2016, 4:56 PM
gerritbot added a comment.Mar 29 2016, 10:01 AM

Change 242494 restored by ArielGlenn:
tox integration to run flake8

Reason:
getting this going finally

https://gerrit.wikimedia.org/r/242494

gerritbot added a comment.Mar 29 2016, 10:11 AM

Change 280169 had a related patch set uploaded (by Hashar):
tox integration to run flake8

https://gerrit.wikimedia.org/r/280169

gerritbot added a project: Patch-For-Review.Mar 29 2016, 10:11 AM

Change 242494 merged by ArielGlenn:
tox integration to run flake8

https://gerrit.wikimedia.org/r/242494

gerritbot added a comment.Mar 29 2016, 10:14 AM

Change 280169 merged by ArielGlenn:
tox integration to run flake8

https://gerrit.wikimedia.org/r/280169

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL