Page MenuHomePhabricator
Create Task
Maniphest T55427

New field and index on recentchanges table for RC_EXTERNAL
Closed, InvalidPublic
Actions

Description

Short description:

Add a new field and index to allow differentiation between types of RC_EXTERNAL changes. Currently Wikibase is the only thing using RC_EXTERNAL. To allow Flow to utilize RC_EXTERNAL and let Wikibase continue doing everything it does now a differentiator is required.

Which wikis are affected:

all?

Which tables:

recentchanges

What is the change to those tables:

ALTER TABLE recentchanges ADD rc_external_type VARBINARY(255) NULL DEFAULT NULL;
CREATE INDEX rc_type ON recentchanges(rc_type, rc_external_type);

Links to gerrit changes and/or other related bug reports.

https://bugzilla.wikimedia.org/53230
https://gerrit.wikimedia.org/r/#/c/81277

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53230

Details

Reference
bz53427

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:54 AM
• bzimport added projects: WMF-General-or-Unknown, Schema-change.
• bzimport set Reference to bz53427.
• bzimport added a subscriber: Unknown Object (MLST).
EBernhardson created this task.Aug 27 2013, 9:36 PM
EBernhardson added a comment.Sep 9 2013, 10:40 PM

After further review we have decided the index is unnecessary and the size of this field should be 16 rather than 255.

The change required is now just:

ALTER TABLE recentchanges ADD rc_external_type VARBINARY(16) NULL DEFAULT
NULL;

Reedy added a comment.Oct 17 2013, 12:37 AM

Where's the accompanying changeset for this as 81277 has been abandoned? Or should this bug be closed as INVALID or similar?

EBernhardson added a comment.Oct 17 2013, 6:06 PM

As mentioned by reedy, after consultation with wikitech and other interested
parties the solution to this problem changed and there is no longer a need to
add rc_external_type to the recentchanges table.

The solution taken involves replacing rc_type int field in recentchanges with a new rc_source varbinary(16) field.

This has been superseeded by bug 55844

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL