Page MenuHomePhabricator
Create Task
Maniphest T55429

Update DSR computation to ignore fostered content
Closed, ResolvedPublic
Actions

Description

In bug 50502 comment 7, Guillaume reported:

In this edit, a table was duplicated (but it wasn't in a template):

https://fr.wikipedia.org/w/index.php?&diff=96159772

I was able to replicate this in Chrome. In addition, I was able to download the original Parsoid HTML for that old-id, the wikitext for that old-id, edit the HTML locally and verify the table duplication on the command line as follows.

$ node parse --html2wt --selser --oldhtmlfile /tmp/fr.html --oldtextfile /tmp/fr.orig.wt < /tmp/fr.edited.html > /tmp/fr.edited.wt

Investigating ...

Version: unspecified
Severity: normal

Details

Reference
bz53429

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:55 AM
• bzimport added a project: Parsoid-Serializer.
• bzimport set Reference to bz53429.
ssastry created this task.Aug 27 2013, 9:42 PM
ssastry added a comment.Aug 27 2013, 9:50 PM

Verified on HTML output generated by latest master (84fac157) -- this rules that that is just a problem with old cached html.

ssastry added a comment.Aug 27 2013, 10:18 PM

Traced this to buggy DSR on a paragraph before fostered content. This only happens when a DSR carryign element (like a link) gets fostered out of the table. The DSR for the paragraph effectively spanned the actual start till the end of the fostered element -- which then causes duplication of table content till that point.

gerritbot added a comment.Aug 27 2013, 11:16 PM

Change 81429 had a related patch set uploaded by Subramanya Sastry:
(Bug 53429) Fixed buggy fostered-node handling in DSR computation

https://gerrit.wikimedia.org/r/81429

gerritbot added a comment.Aug 28 2013, 1:15 AM

Change 81429 merged by jenkins-bot:
(Bug 53429) Fixed buggy fostered-node handling in DSR computation

https://gerrit.wikimedia.org/r/81429

gpaumier added a comment.Aug 28 2013, 6:02 AM

Awesome. Thank you Subbu :)

ssastry added a comment.Aug 28 2013, 4:27 PM

The fix and new code is deployed on production. However, because of caching reasons, you should make a null wikitext source edit on that page so that the old html is purged from the cache. On a new VE edit, you should see the fix working without corrupting the page.

We could have purged the cache completely, but we think this problem only affects a small fraction of pages and it seems better to just wait for template changes and wikitext source edits to gradually purge the bad versions.

I am closing this now, but please reopen if the problem isn't fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL