UploadWizard has a logging library with the same object name as core
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Mattflaschen-WMF
	Aug 28 2013, 3:46 AM

Description

UploadWizard has its own logging library (mw.Log.js) that creates an object/function (mw.log) with the exact same name as core (resources/mediawiki/mediawiki.log.js).

The quick fix is to rename UploadWizard's. Better is to get rid of UploadWizard's and use core's.

Version: unspecified
Severity: normal

Details

Reference: bz53453

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T51987 UploadWizard has some pretty awful code in places (tracking)
		Resolved		None	T55453 UploadWizard has a logging library with the same object name as core

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:56 AM

• bzimport added a project: UploadWizard.

• bzimport set Reference to bz53453.

• bzimport added a subscriber: Unknown Object (MLST).

• Mattflaschen-WMF created this task.Aug 28 2013, 3:46 AM

https://gerrit.wikimedia.org/r/#/c/79917/

Change 79917 had a related patch set uploaded by MarkTraceur:
No need to use custom mw.log anymore

https://gerrit.wikimedia.org/r/79917

Change 79917 merged by jenkins-bot:
No need to use custom mw.log anymore

https://gerrit.wikimedia.org/r/79917

Woohoo.

• Gilles added a project: Multimedia.Dec 4 2014, 10:15 AM

• Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:21 AM

• Gilles moved this task from Untriaged to Done on the Multimedia board.

• Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:21 AM

• Mattflaschen-WMF unsubscribed.Dec 9 2014, 3:49 AM

UploadWizard has a logging library with the same object name as coreClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

UploadWizard has a logging library with the same object name as core
Closed, ResolvedPublic
Actions

Related Objects
Search...