Page MenuHomePhabricator

Author and title links in pop-up video player don't work
Closed, ResolvedPublic

Description

After a video finishes playing in TimedMediaHandler's pop-up player, it shows links for both the title and author. The links are valid, but for some reason clicking on them doesn't work (in Firefox at least). There must be some Javascript hijacking the click action and preventing it from working.

For an example, go to https://en.wikipedia.org/wiki/American_sign_language and click on the first video.


Version: unspecified
Severity: major

Details

Reference
bz53493

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:59 AM
bzimport set Reference to bz53493.

mdale wrote:

line 730 of jquery.ui.dialog.js seems to be the culprit:
if ($(event.target).zIndex() < $.ui.dialog.overlay.maxZ) {

Our event.target zindex is 3 while $.ui.dialog.overlay.maxZ is 1001

Its unfortunate z-index does not stack for child elements, since the dialog box its-self is in range.

seems to work fine if we just comment out the respective z-indexes and relay on the dom order which appears to be fine in testing.
https://gerrit.wikimedia.org/r/81570

(In reply to comment #0)

After a video finishes playing in TimedMediaHandler's pop-up player, it shows
links for both the title and author. The links are valid, but for some reason
clicking on them doesn't work (in Firefox at least). There must be some
Javascript hijacking the click action and preventing it from working.

For an example, go to https://en.wikipedia.org/wiki/American_sign_language
and click on the first video.

Both links for this example work now in Firefox 23.0.1 for me.

(In reply to comment #1)

seems to work fine if we just comment out the respective z-indexes and relay
on the dom order which appears to be fine in testing.
https://gerrit.wikimedia.org/r/81570

That patch has been merged.

Seems like this problem is FIXED. Closing.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:21 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:20 AM