Page MenuHomePhabricator

Support 'ondiscussionpage:' for LQT compatibility
Closed, DeclinedPublic

Description

LQT's search uses the 'ondiscussionpage:' feature of Lucene, please implement it in Cirrus before Lucene is removed from WMF production so that LQT search does not break on Wikimedia wikis.


Version: master
Severity: enhancement

Details

Reference
bz53512

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:01 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz53512.
bzimport added a subscriber: Unknown Object (MLST).

Will do. Right next to ondiscussionpage: it looks like there is also inthread:. Do you need that as well?

Do either of these make results that are useful in general search? If so we should document them on http://en.wikipedia.org/wiki/Help:Searching . That is where I found the features I have implemented.

(In reply to comment #1)

Will do. Right next to ondiscussionpage: it looks like there is also
inthread:. Do you need that as well?

alex@alex:/var/www/MediaWiki/Git/extensions/LiquidThreads (master)$ grep inthread * -R
alex@alex:/var/www/MediaWiki/Git/extensions/LiquidThreads (master)$

Probably not.

(In reply to comment #1)

Do either of these make results that are useful in general search? If so we
should document them on http://en.wikipedia.org/wiki/Help:Searching . That
is
where I found the features I have implemented.

On the English Wikipedia? No, that wiki does not have LiquidThreads.

Honestly its pretty useless on LQT. In my experiance the feature causes more problems then its worth due to the horrid UI. Some sites (Wikinews) use css to hide the search bar entirely due to spam resulting from this feature.

Whether or not the UI is good not having this would still break a feature in mediawiki.org. I'm raising the priority back to normal as this blocks switching to the primary search backend for mediawiki.org, imho.

Well, I made Gerrit change 81601 so that LQT can survive the default changeover. But this is needed before Lucene can be removed from WMF production.

(In reply to comment #3)

Honestly its pretty useless on LQT. In my experiance the feature causes more
problems then its worth due to the horrid UI. Some sites (Wikinews) use css
to
hide the search bar entirely due to spam resulting from this feature.

That's because of bug 37801

Lowering importance as we don't have plans to remove Lucene search from production for a while, even for wikis that are using CirrusSearch.

Does this still matter? Are we still using this feature?

Yes. As far as I can remember it's still used when you submit an LQT search form.

We're not going to implement this for Cirrus. Flow will have Cirrus integration. We should use Flow instead.

lsearchd will probably be running as secondary for awhile still so the search won't disappear immediately.