Page MenuHomePhabricator

bad globecoordinate data values in wikidata
Closed, ResolvedPublic

Description

On Monday when new code was deployed to Wikidata, the DataValue (and api) was changed to disallow null data in the globecoordinate value's precision field.

This caused a problem when editing an item, and claims (including unrelated claims) on the item got resaved. Many globecoordinate claims in the database have null precision. Then the system regarded these globecoordinate values as "bad", invalid, undeserializable.

To further complicate the problem, these "bad" values were actually being stored in the database with datavalue type = "bad", losing knowledge that these had been "globecoordinate".

We updated the software to allow null precision again, for now. Saving globecoordinate with null is okay now, although deprecated and discouraged.

It was possible for my bot to go through affected items and set the datavalue type back to "globecoordinate" to allow them to be valid again. This fixed any "broken" items.


Version: master
Severity: normal

Details

Reference
bz53520

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:01 AM
bzimport added a project: DataValues.
bzimport set Reference to bz53520.
bzimport added a subscriber: Unknown Object (MLST).

reporting this for the record

michiel1972 wrote:

There are also many claims without specification of the Globe. Can it also be allowed to accept empty globe again?.

[You can comment without reopening - this bug report was about *bad* values, hence closing again as FIXED]

Verified in Wikidata demo time