Page MenuHomePhabricator

VisualEditor: Images after template are shielded and uneditable in RTL
Closed, ResolvedPublic

Description

I could not replicate this in LTR wikis (en.wiki or MediaWiki.org) but I suspect this is not so much ltr/rtl but floating behavior of the templates and images.

See example here:
https://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9%D7%AA:Mooeypoo/%D7%A2%D7%95%D7%A8%D7%9A_%D7%97%D7%96%D7%95%D7%AA%D7%99/%D7%91%D7%93%D7%99%D7%A7%D7%95%D7%AA_%D7%95%D7%9E%D7%A9%D7%97%D7%A7%D7%99%D7%9D?veaction=edit

The top two images are regular images (not templates) - they are perfectly editable if you remove the template at the top. They got their shielded status after I inserted that template.

Steps to reproduce:

  1. Edit a page
  2. Insert some image (or more) to top
  3. Save page
  4. Edit again, insert template "{{עליות}}" just above the images.
  5. Save.
  6. Edit again. Observe: The images jumped to the left (wrong float side) and are now uneditable.
  7. Interesting fact: Remove the template and save, then go back into the editor and the images are still uneditable.

Version: unspecified
Severity: normal

Details

Reference
bz53542

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:03 AM
bzimport set Reference to bz53542.

Correction: images jump to the *right* (wrong floating side in RTL wikis) not left. Apparently my sense of directions needs its own bug report.

This seems to be fixed now with the change of images and the way we render shields.