Page MenuHomePhabricator

SpecialMobileDiff throwing warnings about UTF-8
Closed, InvalidPublic

Description

Warning: DOMDocument::loadHTML() [<a href='domdocument.loadhtml'>domdocument.loadhtml</a>]: Input is not proper UTF-8, indicate encoding ! in Entity, line: 389
in /usr/local/apache/common-local/php-1.22wmf14/extensions/MobileFrontend/includes/specials/SpecialMobileDiff.php on line 192

That's right around the comment that says "// haaaacccckkkkk" :P


Version: unspecified
Severity: normal

Details

Reference
bz53551

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:04 AM
bzimport set Reference to bz53551.
bzimport added a subscriber: Unknown Object (MLST).

Doesn't look widespread:

maxsem@fenari:~$ cat /home/wikipedia/syslog/apache.log | grep -c loadHTML
1

Will be taken care of when we have human-friendly diffs on mobile, unlike the ones we have now:P

So what is the next step with fixing this problem?

So essentially... won't fix? If so please close it with why. You hinted at replacing diff's altogether. What would these look like? What the existing JavaScript would do?

Ping. Please update this bug report so it is actionable. Closing until that happens.