Page MenuHomePhabricator

Parser::parse() sent null title
Closed, ResolvedPublic

Description

This extension doesn't behave nicely when parsing from the command line--that $wgTitle looks suspicious!

I'm currently getting the following stacktrace from CirrusSearch:

[29-Aug-2013 20:54:16] Catchable fatal error: Argument 2 passed to Parser::parse() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSParser.php on line 297 and defined at /usr/local/apache/common-local/php
-1.22wmf15/includes/parser/Parser.php on line 351
Server: terbium
URL: http://[unknown-host]
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(351): Parser::parse()
#1 /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSParser.php(297): Parser->parse('{{RSSPost | tit...', NULL, Object(ParserOptions))
#2 /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSParser.php(331): RSSParser->sandboxParse('{{RSSPost | tit...')
#3 /usr/local/apache/common-local/php-1.22wmf15/extensions/RSS/RSSHooks.php(96): RSSParser->renderFeed(Object(Parser), Object(PPFrame_DOM))
#4 [internal function]: RSSHooks::renderRss('http://blog.wik...', Array, Object(Parser), Object(PPFrame_DOM))
#5 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(3992): call_user_func_array(Array, Array)
#6 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Preprocessor_DOM.php(1181): Parser->extensionSubstitution(Array, Object(PPFrame_DOM))
#7 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(3121): PPFrame_DOM->expand(Object(PPNode_DOM), 0)
#8 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(1201): Parser->replaceVariables('== Gallery ==?<...')
#9 /usr/local/apache/common-local/php-1.22wmf15/includes/parser/Parser.php(388): Parser->internalParse('== Gallery ==?<...')
#10 /usr/local/apache/common-local/php-1.22wmf15/includes/content/WikitextContent.php(300): Parser->parse('== Gallery ==?<...', Object(Title), Object(ParserOptions), true, true, 637440)
#11 /usr/local/apache/common-local/php-1.22wmf15/includes/WikiPage.php(3514): WikitextContent->getParserOutput(Object(Title), 637440, Object(ParserOptions))
#12 /usr/local/apache/common-local/php-1.22wmf15/includes/PoolCounter.php(222): PoolWorkArticleView->doWork()
#13 /usr/local/apache/common-local/php-1.22wmf15/includes/WikiPage.php(1126): PoolCounterWork->execute()
#14 /usr/local/apache/common-local/php-1.22wmf15/includes/Article.php(1811): WikiPage->getParserOutput(Object(ParserOptions), NULL)
#15 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/CirrusSearchTextSanitizer.php(36): Article->getParserOutput()
#16 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/CirrusSearch.body.php(53): CirrusSearchTextSanitizer::getSantizedTextFromTitle(Object(Title))
#17 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/forceSearchIndex.php(215): CirrusSearch->getTextFromContent(Object(Title), Object(WikitextContent))
#18 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/forceSearchIndex.php(89): ForceSearchIndex->findUpdates(Object(MWTimestamp), '111542', NULL)
#19 /usr/local/apache/common-local/php-1.22wmf15/maintenance/doMaintenance.php(115): ForceSearchIndex->execute()
#20 /usr/local/apache/common-local/php-1.22wmf15/extensions/CirrusSearch/forceSearchIndex.php(304): require_once('/usr/local/apac...')
#21 /usr/local/apache/common-local/multiversion/MWScript.php(97): require_once('/usr/local/apac...')
#22 {main}


Version: master
Severity: major

Details

Reference
bz53563

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:04 AM
bzimport set Reference to bz53563.

Pls. indicate the version of the Extension:RSS.. make sure to run latest(!) RSS and core.

This is latest WMF branch, 1.22wmf15

I mean, what version of the extension RSS do you use ?

Please checkout the latest version, see https://www.mediawiki.org/wiki/Extension:RSS

cd extensions
git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/RSS.git

We are using the latest version of RSS (1.22, f2948e5) in 1.22wmf15.

Did you mean 2.22, I suppose... based on the hash.

Can you join #wikimedia-dev please ?

Chad, I need the RSS feed url. If you prefer, you can send it to by mail.

just checked the latest RSS with latest Wikimedia (1.22alpha): works

(In reply to comment #7)

just checked the latest RSS with latest Wikimedia (1.22alpha): works

This is easy to reproduce. Just copy the code from
https://www.mediawiki.org/wiki/Extension:RSS#Example
and run it through the maintenance/parse.php script.

Change 82366 had a related patch set uploaded by PleaseStand:
Fix parsing from CLI

https://gerrit.wikimedia.org/r/82366

Change 82366 merged by Wikinaut:
Fix parsing from CLI; bumped to version 2.23

https://gerrit.wikimedia.org/r/82366

thx for valuable help, commit. code review !