Page MenuHomePhabricator
Create Task
Maniphest T55564

IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification
Closed, ResolvedPublic
Actions

Description

EDIT: There is no longer a link to the user in the flyout, but it still applies on Special:Notifications.

In Notifications, can we link IPs to their special:contributions page, instead of their userpage?

eg. We currently have:
Your edit on [[Mike Patton]] has been reverted by [[User:124.181.111.127|124.181.111.127]]. (Show changes)

we want:
Your edit on [[Mike Patton]] has been reverted by [[Special:Contributions/124.181.111.127|124.181.111.127]]. (Show changes)

This would be consistent with the way IPs are linked in all History pages, eg https://en.wikipedia.org/w/index.php?title=Mike_Patton&action=history

See Also:
T55174: All Echo notifications mentioning the acting user ("agent") should have his nick linked to his user page

Details

Reference
bz53564
SubjectRepoBranchLines +/-
IP addresses should link to Special:Contributions instead of user page for revertmediawiki/extensions/Echomaster+26 -10
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:04 AM
• bzimport added a project: Notifications.
• bzimport set Reference to bz53564.
• bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.Aug 29 2013, 9:11 PM
• Spage added a comment.Sep 23 2013, 8:47 PM

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/239

Legoktm added a comment.Oct 7 2013, 9:13 PM

'notification-reverted2' => 'Your {{PLURAL:$4|edit on [[:$2]] has|edits on [[:$2]] have}} been {{GENDER:$1|reverted}} by [[User:$1|$1]]. $3',

The solution here would probably to just use $1, and have echo figure out whether to make a link to the user page or contributions page, and send that as a parameter.

Legoktm added a comment.Aug 28 2014, 12:43 AM
  • Bug 70116 has been marked as a duplicate of this bug. ***
• werdna unsubscribed.Dec 10 2014, 5:02 PM
matthiasmullie triaged this task as Medium priority.Dec 11 2014, 11:27 AM
matthiasmullie added projects: Collaboration-Team-Triage, good first task.
matthiasmullie set Security to None.
Liuxinyu970226 subscribed.Feb 12 2015, 3:31 AM
01tonythomas mentioned this in T76199: Goal: Newsletter extension for MediaWiki.Mar 27 2015, 7:28 PM
Ricordisamoa subscribed.Mar 27 2015, 9:50 PM
Tinaj1234 claimed this task.Mar 28 2015, 6:12 PM
Tinaj1234 removed Tinaj1234 as the assignee of this task.Apr 2 2015, 7:21 AM
xSavitar subscribed.Sep 13 2015, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2015, 7:41 PM
xSavitar added a comment.Sep 16 2015, 6:07 PM

Wow, i have been researching a little about this bug. Is it still there or has it been fixed. I think i can challenge myself to fix this bug. I understand that to do hear. But if i have any questions as regards the bug, i will ask.

• Mattflaschen-WMF assigned this task to xSavitar.Sep 16 2015, 6:59 PM
• Mattflaschen-WMF subscribed.

It's still open. If you have questions, you can ask in #wikimedia-collaboration.

• Mattflaschen-WMF updated the task description. (Show Details)Sep 16 2015, 7:27 PM
• Mattflaschen-WMF renamed this task from IP addresses should link to Special:Contributions instead of userpage to IP addresses should link to Special:Contributions instead of userpage, e.g. on revert notification.Sep 17 2015, 11:16 PM
gerritbot subscribed.Sep 17 2015, 11:18 PM

Change 239301 had a related patch set uploaded (by Mattflaschen):
IP addresses should link to Special:Contributions instead of userpage

https://gerrit.wikimedia.org/r/239301

gerritbot added a project: Patch-For-Review.Sep 17 2015, 11:18 PM
gerritbot added a comment.Sep 17 2015, 11:27 PM

Change 239301 had a related patch set uploaded (by D3r1ck01):
IP addresses should link to Special:Contributions instead of userpage e.g. revert change

https://gerrit.wikimedia.org/r/239301

gerritbot added a comment.Sep 18 2015, 3:22 AM

Change 239301 abandoned by D3r1ck01:
IP addresses should link to Special:Contributions instead of userpage e.g. revert change

Reason:
Redone

https://gerrit.wikimedia.org/r/239301

gerritbot added a comment.Sep 18 2015, 3:23 AM

Change 239301 restored by Mattflaschen:
IP addresses should link to Special:Contributions instead of userpage e.g. revert change

Reason:
No need to make a new change. Just amend this one.

https://gerrit.wikimedia.org/r/239301

xSavitar added a comment.Sep 18 2015, 1:01 PM

From the last patch set i have submitted, it fixes the Bug. Thanks to Mattflaschen and EBernhardson for their contributions. They really helped me. Finally the bug is fixed.

matej_suchanek awarded a token.Sep 18 2015, 1:16 PM
matej_suchanek updated the task description. (Show Details)
gerritbot added a comment.Sep 20 2015, 8:01 PM

Change 239301 merged by jenkins-bot:
IP addresses should link to Special:Contributions instead of user page for revert

https://gerrit.wikimedia.org/r/239301

Diffusion mentioned this in rMEXT3c0141378783: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 20 2015, 8:01 PM
• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Sep 20 2015, 8:02 PM
• Mattflaschen-WMF mentioned this in rECHOba4789760c0a: IP addresses should link to Special:Contributions instead of user page for….Sep 20 2015, 8:02 PM
• Mattflaschen-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 20 2015, 8:03 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 20 2015, 9:00 PM
Etonkovidova subscribed.Sep 23 2015, 12:08 AM

Checked in betalabs - reverts made by IP users have a link to Special:Contributions:

Screen Shot 2015-09-22 at 5.01.29 PM.png (281×758 px, 33 KB)

<div class="mw-echo-title">Your edit on <a href="/wiki/User_talk:Etonkovidova"
title="User talk:Etonkovidova">User talk:Etonkovidova</a> has been reverted by
<a href="/wiki/Special:Contributions/xx.x.xxx.xxx" title="Special:Contributions/xx.x.xxx.xxx"></a>. <a href="/w/index.php?title=User_talk:Etonkovidova&amp;oldid=2427&amp;diff=prev" title="User talk:Etonkovidova" class="mw-echo-diff">(Show changes)</a></div>
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 23 2015, 12:08 AM
• DannyH closed this task as Resolved.Sep 24 2015, 5:18 PM
• DannyH subscribed.
Liuxinyu970226 unsubscribed.Sep 25 2015, 10:50 AM
xSavitar awarded a token.Nov 7 2018, 10:27 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 7 2018, 10:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL