Page MenuHomePhabricator

Add the icon near the user name also in RTL interfaces
Closed, ResolvedPublic

Description

Author: rotemliss

Description:
Nowadays, the icon near the user name is disabled in RTL interfaces, but we in
Hebrew Wikipedia, Wikiquote and Wikisource re-added it in our Monobook.css, and
it works well. I suggest to cancel the hidding of it also in the global rtl.css.

I will create a patch soon.


Version: 1.5.x
Severity: trivial

Details

Reference
bz5357

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:10 PM
bzimport set Reference to bz5357.
bzimport added a subscriber: Unknown Object (MLST).

rotemliss wrote:

Patch for CVS HEAD

Patch, deletes the CSS part in "rtl.css" which hides the icon. I've tested the
patch and it works well, just like Wikipedia.

Attached:

rotemliss wrote:

Comment on attachment 1466
Patch for CVS HEAD

This is a patch for HEAD, or MAIN, or something like that (the main tree, where
version 1.6 is developed, and which Wikimedia projects use). Patch for REL1_5
is coming soon.

robchur wrote:

Observing a fresh RTL test wiki, it doesn't appear that the icon is hidden at all.

rotemliss wrote:

(In reply to comment #3)

Observing a fresh RTL test wiki, it doesn't appear that the icon is hidden at all.

Are you trying the recent 1.6cvs (alpha) version? Also, please check
skins/monobook/rtl.css for the string "pt-userpage".

rotemliss wrote:

(In reply to comment #4)

Are you trying the recent 1.6cvs (alpha) version? Also, please check
skins/monobook/rtl.css for the string "pt-userpage".

And please see:

rotemliss wrote:

Patch for REL1_5

Patch for REL1_5.

Attached:

rotemliss wrote:

And directly, please see:
http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/skins/monobook/rtl.css?view=markup

Search the line "/* Fix link icons */" - the line after that cancels the icon.

Does your installed Wiki use rtl.css?

robchur wrote:

  1. Using MediaWiki 1.6alpha
  2. It's a Yiddish language RTL wiki
  3. rtl.css appears to be being imported

http://www.anubite.co.uk/wikis/yiddish

rotemliss wrote:

(In reply to comment #8)

  1. Using MediaWiki 1.6alpha
  2. It's a Yiddish language RTL wiki
  3. rtl.css appears to be being imported

http://www.anubite.co.uk/wikis/yiddish

Like in Hebrew Wikipedia, Wikiquote and Wikisource, it contains the following
CSS sector in Monobook.css:

li#pt-userpage,
li#pt-anonuserpage,
li#pt-login {

background:  url('http://yi.wikipedia.org/style/monobook/user.gif') top left

no-repeat;

padding-left: 20px;

}

This monobook.css is copied from Yiddish Wikipedia, which has also fixed the
problem.

robchur wrote:

Quite correct. I apologise.

robchur wrote:

Tested on a fresh install and applied to CVS HEAD.

rotemliss wrote:

Could you please fix it also in CVS REL1_5? It's very minor, and I've tested the
patch on a fresh install of recent 1.5cvs files.

rotemliss wrote:

It's already in the stable version, so there is no need to fix it in REL1_5.