Page MenuHomePhabricator
Create Task
Maniphest T55575

Edit on doubleclick doesn't work in Safari
Closed, ResolvedPublic
Actions

Description

On de.wikipedia [1] there is a report that the "edit on doubleclick" option doesn't work in Safari. According to a post on stackoverflow [2] Safari doesn't implement a click method for DOM elements, which of course breaks the current appoach of the code [3].

[1] https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#Bearbeiten_mit_Doppelklick
[2] http://stackoverflow.com/questions/12925153/jquery-click-works-on-every-browser-but-safari
[3] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/e0f48d66b4f5d7c5dae0421b991e33d9c43af910/resources%2Fmediawiki.action%2Fmediawiki.action.view.dblClickEdit.js

Version: 1.22.0
Severity: normal

Details

Reference
bz53575

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:06 AM
• bzimport added projects: Browser-Support-Apple-Safari, MediaWiki-Page-editing.
• bzimport set Reference to bz53575.
• bzimport added a subscriber: Unknown Object (MLST).
Schnark created this task.Aug 30 2013, 8:23 AM
Volker_E subscribed.Mar 23 2021, 1:43 PM

@Schnark With several years, versions of Safari passed and adapted browser support matrix and code changes, is this ready to be closed?

Krinkle closed this task as Resolved.Mar 23 2021, 7:39 PM
Krinkle claimed this task.

I confirmed that this works in Safari 14, and will assume it also works in all other Grade A versions of Safari that we support. It was a bug in a very old WebKit version that has since been fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL