Page MenuHomePhabricator

Centralnotice UK broken sometimes
Closed, ResolvedPublic

Description

Some people reporting that the link in the UK sitenotice is not working properly.

Please add below browser + output of http://geoiplookup.wikimedia.org/ and any other useful info (does it happen all the time, or only sometimes?)


Version: unspecified
Severity: normal

Details

Reference
bz53650

Related Objects

StatusSubtypeAssignedTask
DeclinedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:10 AM
bzimport set Reference to bz53650.
bzimport added a subscriber: Unknown Object (MLST).

(only need country output btw, sorry for confusion)

From the emails:

Michael:

The CentralNotice on en.W does not work for me. As I'm in the UK it should redirect to http://www.wikilovesmonuments.org.uk/, but clicking on it does nothing (stays on the same WP page).

Richard:

This has happened to myself and at least one other person, so isn't a one-off glitch. It would be nice to get this working ASAP.

Multiple browsers and platforms.

Code is at https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-template-wlm_2013 . Had a change today, maybe that's causing problems

Could be location related (UK vs GB vs SCT vs ENG, etc etc)

richard.nevell wrote:

Problem happens every time notice is clicked.

Reported on Internet Explorer, Google Chrome, Firefox, and Safari.

Output from geoiplookup:
*Chrome Geo = {"city":"London","country":"GB","lat":"51.514198","lon":"-0.093100","IP":"2.222.167.57","netmask":"24"}

Yup, GB is the correct code. Easy fix: Add GB (and just keep around UK to be sure) at https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-template-wlm_2013

It seems the GB/UK was playing up. I changed it to GB in the centralnotice, should work fine, please confirm.

richard.nevell wrote:

Output from geoiplookup:
*Firefox says GB
*Safari says GB

Added Ryan, he created this last year and maybe he can review it if we didn't overlook something.

I would expect that if there is not a country match that the banner would send the user to http://www.wikilovesmonuments.org/?pk_campaign=Centralnotice . That's how we crashed our website two years ago ;-)

This appears to have been resolved and the banner is now working.