Page MenuHomePhabricator

Broken link option is confusing in preferences
Closed, InvalidPublic

Description

Apparently, broken link formatting handling was moved completely into CSS in 1.6 (includes/Skin.php),
which causes one minor issue on the user preferences page. If the "Format broken links like this
(alternative: like this?)." option is switched off, the first "like this", which should continue to be red
without a question mark afterward, turns into "like this?" with normal text and a red question mark.


Version: 1.6.x
Severity: trivial
Platform: Macintosh
URL: http://en.wikipedia.org/wiki/Special:Preferences

Details

Reference
bz5366

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:09 PM
bzimport set Reference to bz5366.
bzimport added a subscriber: Unknown Object (MLST).

omniplex wrote:

For browsers without CSS support this preference is
really confusing, because it has no effect at all no
matter what the user tries (apparently there's no
skin with a solution for legacy / text browsers)

Bug is still present in 1.13-alpha on enwiki. Omniplex also has
a good point -- the preference should probably indicate "(requires
CSS support)" or something similar.

(In reply to comment #0)

Apparently, broken link formatting handling was moved completely into CSS in
1.6 (includes/Skin.php),
which causes one minor issue on the user preferences page. If the "Format
broken links like this
(alternative: like this?)." option is switched off, the first "like this",
which should continue to be red
without a question mark afterward, turns into "like this?" with normal text and
a red question mark.

I can reproduce this.

As for needing CSS support, this is pretty basic and standard. Most pages on the web I've seen look broken or ugly without it.

*** Bug 15875 has been marked as a duplicate of this bug. ***

I wouldn't agree, that websites look ugly without CSS.

Actually w3m is a very fast and convenient browser to do most of my work on the Wikipedia, but it has no CSS support, too.

I suppose that users of CSS-enabled browsers do not really need this preference.

There are two solutions:

  1. we go back to non-CSS handling of this feature (who needs this otherwise?)
  2. one of the skins will handle it in text (for example simple or standard)

What do you think?

At least temporarily mark the item in the menus with "(CSS)" so we w3m-emacs etc. users could know that there was something funny going on for this item.

preference was removed with bug 27619