Page MenuHomePhabricator

VisualEditor: Trigger keys can end up in CE surface, but not in DM
Closed, ResolvedPublic1 Estimated Story Points

Description

A user reported a problem to use the "clear formatting" shortcut with a french AZERTY keyboard. The shortcut is "Ctrl + \", but "\" is only accessible as "AltGr + 8".

First, even with, "Ctrl + AltGr + 8", the shortcut doesn't work. I was unable to find a keyboard combination that triggers the "clear formatting" shortcut. When using a classic QWERTY keyboard, "Ctrl + \" works on the same computer/browser.
See https://bugzilla.wikimedia.org/show_bug.cgi?id=51507

But, when testing, I noticed an other problem, with a behaviour depending on OS/browser when using "Ctrl + AltGr + 8" with text selected:

  • On W7 + Chrome 29, the selected text is replaced by "\", but VE doesn't see any modification: save is disabled, undo is disabled, ...
  • On W7 + Firefox 23, the selected text is replaced by "\", and VE sees that text has been modified
  • On Ubuntu 12.04 LTS + Firefox 20, a user report that all page is selected.

Same kind of problems happen with "Ctrl + Alt + 8", "Alt + 8", ... or other digits.

https://fr.wikipedia.org/w/index.php?title=Wikipédia:ÉditeurVisuel/Avis#Raccourci_clavier_pour_effacer_la_mise_en_forme


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51507

Details

Reference
bz53682

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:13 AM
bzimport set Reference to bz53682.

Trigger issue is split to bug 56452. Re-titled.

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 15 2015, 12:31 AM
Jdforrester-WMF set Security to None.

Change 247800 had a related patch set uploaded (by Divec):
Diff richtext to build model changes

https://gerrit.wikimedia.org/r/247800

Actually I think this was already fixed before Change 247800: On Ubuntu 15.10 with French keyboard, Alt+8 into a non-collapsed selection seems to overwrite the selection with \ in both the DOM and the DM, in both Firefox 42 and Chromium 45.

Esanders claimed this task.