Page MenuHomePhabricator

VisualEditor: Inserting some content in a QA script doesn't round-trip (null diff) - failure to inserting CE content into DM somehow?
Closed, ResolvedPublic0 Estimated Story Points

Description

Author: rachelqa99

Description:
shows error message

I got this message when running a test automation script, that puts in a line of code and tries to save it. It doesn't recognize the new line of code I put in, so it gives this error message upon save. Not sure if you are aware of this particular scenario, which is why I am submitting it.


Version: unspecified
Severity: normal

Attached:

matchingrev.png (546×1 px, 72 KB)

Details

Reference
bz53721

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:47 AM
bzimport set Reference to bz53721.

rachelqa99 wrote:

feature script

Attached:

rachelqa99 wrote:

this is running off of test2

rachelqa99 wrote:

Possibly a situation caused by bug 53360 which is marked as resolved.

(In reply to comment #0)

Created attachment 13227 [details]
shows error message

I got this message when running a test automation script,

Yes, this is the normal (you tried to get the diff but as far as we're concerned, no changes were made to the page).

that puts in a line of code and tries to save it. It doesn't recognize the new
line of code I put in, so it gives this error message upon save.

What "line of code" does it insert? Where does it insert it? On what page? On what wiki? Can you reproduce manually or does this only happen with the script?

(In reply to comment #3)

Possibly a situation caused by bug 53360 which is marked as resolved.

The fix for bug 53360 is running on test2 right now, so almost certainly not related to that bug.

Attached:

matchingrev.png (546×1 px, 72 KB)

rachelqa99 wrote:

I am adding the line of text This is a test at the beginning of the page into the Selenium user's homepage on test2. There is a bunch of already existing text below it, I am just trying to add a new line at the begining of the page, "This is a test" and hit Return key for a new line. I can't seem to reproduce it manually.

I think this might be a real bug, but I think it might take some particular piece of hardware to trigger it.

WebDriver/Selenium has two ways of sending a newline to the browser

:enter
:return

":return" is intended to emulate the "Return" key on a normal keyboard; ":enter" is intended to emulate the "Enter" key on a numeric keypad.

In this test, when we type a string plus :return in VE, the diff view is correct, and the test would pass. But when the test sends a string plus :enter in VE, VE does not recognize that the contents of the edit page has changed.

I tried to reproduce this issue manually using a Macintosh USB keyboard on a Macbook Pro laptop but both the Return key and Enter key on that particular piece of hardware worked correctly with VE.

I suggest trying out Return (on the keyboard) and Enter (on the numeric keypad) on a few keyboards to make sure we don't see this in the wild.

A clarification about each case we tried in the automated test:

  • type a string and the string is shown correctly in CE and DM
  • type a string and :return and both the string and the empty line are shown correctly in CE and DM
  • but type a string and :enter and CE correctly shows *both* the string *and* the empty line but DM shows *neither* the string nor the empty line. That is, the :enter command is recognized in CE but seems to have the effect of making all the changes in CE invisible to DM.

Is this still a problem, or can the task be resolved?

Jdforrester-WMF claimed this task.

I'm going to provisionally mark this as fixed as it appears to now work.