Page MenuHomePhabricator

some favicon provides several icons
Closed, ResolvedPublic

Description

The favicon introduced by https://gerrit.wikimedia.org/r/#/c/82119/ for bug 53653 is slightly bigger: Bin 4286 -> 7886 bytes and seems to include 3 icons:

docroot/bits/favicon/wikivoyage.ico: MS Windows icon resource - 3 icons, 16x16, 256-colors

That used to only ship 1 icon:

git checkout d6cdbbb^
$ file docroot/bits/favicon/wikivoyage.ico
docroot/bits/favicon/wikivoyage.ico: MS Windows icon resource - 1 icon

Looking at our favicons, there are several of them providing more than one icon. I am wondering whether it is really needed.

$ find . -name '*.ico' -type f -exec file {} \;
./docroot/bits/favicon/black-globe.ico: MS Windows icon resource - 3 icons, 48x48, 256-colors
./docroot/bits/favicon/chapcom.ico: MS Windows icon resource - 1 icon
./docroot/bits/favicon/commons.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/community.ico: MS Windows icon resource - 4 icons, 32x32, 256-colors
./docroot/bits/favicon/incubator.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/internal.ico: MS Windows icon resource - 1 icon
./docroot/bits/favicon/labs.ico: MS Windows icon resource - 3 icons, 16x16, 256-colors
./docroot/bits/favicon/mediawiki.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/office.ico: MS Windows icon resource - 4 icons, 16x16, 256-colors
./docroot/bits/favicon/piece.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/spcom.ico: MS Windows icon resource - 1 icon
./docroot/bits/favicon/testwikidata.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/toollabs.ico: MS Windows icon resource - 3 icons, 16x16, 256-colors
./docroot/bits/favicon/usability.ico: MS Windows icon resource - 3 icons, 48x48, 256-colors
./docroot/bits/favicon/wikibooks.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/wikidata.ico: MS Windows icon resource - 2 icons, 16x16, 16-colors
./docroot/bits/favicon/wikimania.ico: MS Windows icon resource - 1 icon
./docroot/bits/favicon/wikinews.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/wikipedia.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/wikiquote.ico: MS Windows icon resource - 1 icon
./docroot/bits/favicon/wikisource.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/wikispecies.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/wikiversity.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/wikivoyage.ico: MS Windows icon resource - 3 icons, 16x16, 256-colors
./docroot/bits/favicon/wiktionary/en.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/bits/favicon/wiktionary/si.ico: MS Windows icon resource - 1 icon
./docroot/bits/favicon/wmf.ico: MS Windows icon resource - 2 icons, 16x16, 256-colors
./docroot/press/favicon.ico: MS Windows icon resource - 1 icon
./docroot/test/favicon4.ico: MS Windows icon resource - 3 icons, 48x48, 256-colors
./docroot/ukwikimedia/favicon.ico: MS Windows icon resource - 1 icon


Version: wmf-deployment
Severity: minor

Details

Reference
bz53741

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:49 AM
bzimport set Reference to bz53741.
bzimport added a subscriber: Unknown Object (MLST).

It would be worth investigating browser support for larger favicon images. I'm pretty sure that at least IE running at high DPI (a fairly common situation) can take advantage of larger images to provide larger, non-blurry favicons for users. Google "favicon multiple sizes" for some useful results.

The resources should normally not have more than 2 icons though. For example, office.ico contains 48x48 and 256x256 versions, and I doubt these are ever used. They're certainly not worth the extra download size.

I'm pretty sure the multiple icons are intended; they're displayed when you bookmark pages in various ways on various systems.

I think Isarra was working on favicons semi-recently, CC-ing her.

Yeah, the multiple sizes are for handling different pixel density screens (16x16 and 32x32) as well as different uses (larger ones will be used for bookmarks and such, unless you use an apple device with apparently requires a separate file for that).

The first two sizes we definitely need. Whether or not the others are worth it is more debatable, but seemed like more trouble than it was worth to worry about when I was tinkering with them.

  • This bug has been marked as a duplicate of bug 45036 ***

dupe marked following a discussion with Tomasz. We effectively want to ship several sizes.