Page MenuHomePhabricator

Impossible to insert the "ę" character when editing in Module: namespace with the code editor
Closed, ResolvedPublic

Description

[Please move this to a different component if applicable, I'm not sure where the editor comes from.]

It is impossible to insert the "ę" or "Ę" characters (latin letter "e"/"E" with ogonek) from keyboard when editing in Module: namespace with the code editor on the Polish Wikipedia.

"ę" is inserted on the Polish keyboard using AltGr+e (aka Ctrl+Alt+e). If the editor uses this as a hotkey, it shouldn't (nor should it use any other Ctrl+Alt combinations).

(Reported at https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne#VisualEditor_a_polskie_diakrytyki)


Version: unspecified
Severity: normal

Details

Reference
bz53763

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:50 AM
bzimport added a project: CodeEditor.
bzimport set Reference to bz53763.
bzimport added a subscriber: Unknown Object (MLST).

You want CodeEditor.

I note that I can type ę and Ę fine in CodeEditor from here, where the key combinations are "<Compose> ; e" and "<Compose> ; E".

I also remapped Ctrl+Alt+E to "ę" temporarily, and I was able to enter that character using that key combination in CodeEditor on a module page on plwiki with no issues (using Firefox 24 on Linux).

@Brad, depending on how exactly you remapped it, the Ctrl+Alt+E might be mapped to "ę" in some lower-level layer, not letting the browser even see it. (I used this a few times to wrestle with some stupid applications which take Ctrl+Alt shortcuts for themselves to take it away from them.)

Some grepping shows ACE Editor uses "Ctrl-Alt-E" / "Command-Option-E" for the "togglerecording" command. This is most likely the culprit.

This seems to be the only Ctrl-Alt shortcut involving regular letters (there are also a few with arrow keys and backspace).

In that case, it looks like you could follow the example in modules/jquery.codeEditor.js near line 151 to disable this command too.

matmarex closed this task as Resolved.EditedDec 11 2023, 11:09 PM

This works correctly these days.

It was apparently fixed by https://github.com/ajaxorg/ace/pull/1463 (d4bdfe33001b4c13134515b0fa53b6b64d8b3ee1) – which was already merged when I was filing this bug :) – and we upgraded to that version in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CodeEditor/+/104510 (early 2014).