Page MenuHomePhabricator
Create Task
Maniphest T55821

Argument 1 passed to SpamBlacklist::filter() must be an array, object given
Closed, ResolvedPublic
Actions

Description

[05-Sep-2013 21:15:32] Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php on line 360 and defined at /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php on line 40
Server: mw1198
Method: POST
URL: http://fr.wikipedia.org/w/api.php
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php(40): SpamBlacklist::filter()
#1 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php(360): SpamBlacklist->filter(Object(Title), '', '')
#2 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php(121): ArticleFeedbackv5Utils::validateSpamBlacklist('', 3252248)
#3 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(834): ApiArticleFeedbackv5->execute()
#4 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(380): ApiMain->executeAction()
#5 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(351): ApiMain->executeActionWithErrorHandling()
#6 /usr/local/apache/common-local/php-1.22wmf15/api.php(73): ApiMain->execute()
#7 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#8 {main}
[05-Sep-2013 21:15:46] Catchable fatal error: Argument 1 passed to SpamBlacklist::filter() must be an array, object given, called in /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php on line 360 and defined at /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php on line 40
Server: mw1148
Method: POST
URL: http://fr.wikipedia.org/w/api.php
Backtrace:
#0 /usr/local/apache/common-local/php-1.22wmf15/extensions/SpamBlacklist/SpamBlacklist_body.php(40): SpamBlacklist::filter()
#1 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/ArticleFeedbackv5.utils.php(360): SpamBlacklist->filter(Object(Title), 'le d??veloppeme...', '')
#2 /usr/local/apache/common-local/php-1.22wmf15/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php(121): ArticleFeedbackv5Utils::validateSpamBlacklist('le d??veloppeme...', 569048)
#3 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(834): ApiArticleFeedbackv5->execute()
#4 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(380): ApiMain->executeAction()
#5 /usr/local/apache/common-local/php-1.22wmf15/includes/api/ApiMain.php(351): ApiMain->executeActionWithErrorHandling()
#6 /usr/local/apache/common-local/php-1.22wmf15/api.php(73): ApiMain->execute()
#7 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#8 {main}

Version: master
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53952

Details

Reference
bz53821

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:54 AM
• bzimport added a project: ArticleFeedbackv5.
• bzimport set Reference to bz53821.
• bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Sep 5 2013, 7:16 PM
Reedy added a comment.Sep 5 2013, 7:19 PM

AFTv5:

		if ( $spam ) {
			$title = Title::newFromText( 'ArticleFeedbackv5_' . $pageId );
			$ret = $spam->filter( $title, $value, '' );
			if ( $ret !== false ) {
				return true;
			}
		}

SpamBlacklist:
function filter( array $links, Title $title = null ) {

		$fname = 'wfSpamBlacklistFilter';

Based on that, $title should presumably be first...

gerritbot added a comment.Sep 5 2013, 8:29 PM

Change 82979 had a related patch set uploaded by Reedy:
Update AFTv5 to wmf/1.22wmf16 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/82979

gerritbot added a comment.Sep 5 2013, 8:29 PM

Change 82979 merged by Reedy:
Update AFTv5 to wmf/1.22wmf16 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/82979

gerritbot added a comment.Sep 5 2013, 8:48 PM

Change 83009 had a related patch set uploaded by Reedy:
Update AFTv5 to wmf/1.22wmf15 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/83009

gerritbot added a comment.Sep 5 2013, 8:49 PM

Change 83009 merged by Reedy:
Update AFTv5 to wmf/1.22wmf15 branch which includes live hack to fix fatal

https://gerrit.wikimedia.org/r/83009

gerritbot added a comment.Sep 5 2013, 9:01 PM

Change 83012 had a related patch set uploaded by Matthias Mullie:
(bug 53821) Update SpamBlacklist related code

https://gerrit.wikimedia.org/r/83012

gerritbot added a comment.Sep 9 2013, 8:16 PM

Change 83012 merged by jenkins-bot:
(bug 53821) Update SpamBlacklist related code

https://gerrit.wikimedia.org/r/83012

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL