Page MenuHomePhabricator

incomplete translation triggers jquery.msg exception
Closed, ResolvedPublic

Description

During the 2013-09-05 deploy, I visited http://test.wikipedia.org/wiki/Sandbox?debug=1&tour=firstedit after sync-common on mw1017 but before scap had started. So testwiki didn't have the rebuilt i18n cache with strings for the new firstedit tour.

In regular RL mode no message appeared and no tour; in debug mode this threw an error:

Failed to load tour ext.guidedTour.tour.firstedit as module. err:
Error: Parse error at position 0 in input: <guidedtour-tour-firstedit-edit-page-title>

...ow new Error( 'Parse error at position ' + pos.toString() + ' in input: ' + inpu...

, dependencies: ["ext.guidedTour.tour.firstedit"]

this is from mediawiki.jqueryMsg.js, I think wikiTextToAst(). This shouldn't happen in production and now scap has finished I can't reproduce; however, the usual behavior of MW i18n with unavailable messages is to dump them out as you'd see with ?uselang=qqx, rather than throw errors. So maybe there's something that can be made more robust in guidedTour or (more likely) in jqueryMsg.

Hmmm. I'm still getting the error on testwiki after scap completed, so maybe this is occurring due to something other than incomplete i18n. testwiki has Parsoid and VE extensions installed, but it's only showing me an [Edit] tab that leads to source editing.


Version: master
Severity: minor

Details

Reference
bz53830

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:55 AM
bzimport set Reference to bz53830.

This is because GuidedTour is using internal jqueryMsg APIs instead of mw.message. The latter behaves as you described (dumping the error into parsed message text).