Page MenuHomePhabricator
Create Task
Maniphest T55851

Enhanced Recent Changes needs hook(s) for customised formatting, similar to OldChangesListRecentChangesLine hook
Closed, ResolvedPublic
Actions

Description

Author: simon.white

Description:
The old (non-js) implementation of ChangesList provides a hook known as OldChangesListRecentChangesLine, which allows extensions to manipulate the rendering of a line of rc output. Today on master, this is at line 682 of ChangesList.php.

The new EnhancedChangesList does not provide a similar hook. This means that it would be difficult if not impossible for extensions to cleanly move functionality across from the old recent changes list.

At present, the obvious available work-arounds are to either patch the hook/behaviour into ChangesList.php, or to prevent users from using the enhanced recent changes list with $wgHiddenPrefs.

Details

Reference
bz53851

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:56 AM
• bzimport added a project: MediaWiki-Recent-changes.
• bzimport set Reference to bz53851.
• bzimport created this task.Sep 6 2013, 1:11 PM
matmarex added a comment.Sep 6 2013, 1:35 PM

The "Old" in "OldChangesListRecentChangesLine" (as opposed to "Enhanced") kind of hints at how this is limited. A similar mechanism (or a generalisation of this one) for enhanced RC would be useful.

duplicatebug added a comment.Sep 8 2013, 9:05 AM

See also bug 46394

matmarex added a comment.Sep 18 2013, 6:34 PM

This is an issue in the core MediaWiki enhanced recent changes, not in the CleanChanges extension.

Aklapper added a comment.Sep 18 2013, 11:11 PM

MatmaRex: Whoops. Thanks for corecting me!

gerritbot added a comment.Apr 23 2014, 7:44 AM

Change 129116 had a related patch set uploaded by Aude:
Introduce EnhancedChangesCacheEntry hook

https://gerrit.wikimedia.org/r/129116

gerritbot added a comment.Aug 19 2014, 10:40 AM

Change 129116 abandoned by Aude:
Introduce EnhancedChangesCacheEntry hook

Reason:
not sure we want this

https://gerrit.wikimedia.org/r/129116

duplicatebug unsubscribed.Dec 13 2014, 11:44 AM
Tobi_WMDE_SW removed aude as the assignee of this task.Jun 9 2015, 1:25 PM
Tobi_WMDE_SW set Security to None.
daniel added a project: Wikidata-Sprint-2015-11-17.Nov 25 2015, 6:03 PM
daniel subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2015, 6:03 PM
daniel added a comment.Nov 25 2015, 7:01 PM

Would it not be sufficient to use the EnhancedChangesListModifyBlockLineData and EnhancedChangesListModifyLineData hooks? The interface is a bit different from OldChangesListRecentChangesLine, but I think it would not be too hard to share most code between them.

matej_suchanek added a project: TestMe.Apr 26 2017, 4:38 PM
matej_suchanek updated the task description. (Show Details)
matej_suchanek removed a subscriber: Wikidata-bugs.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 26 2017, 4:38 PM
matej_suchanek subscribed.Jun 22 2017, 3:24 PM
In T55851#1832143, @daniel wrote:

Would it not be sufficient to use the EnhancedChangesListModifyBlockLineData and EnhancedChangesListModifyLineData hooks? The interface is a bit different from OldChangesListRecentChangesLine, but I think it would not be too hard to share most code between them.

In fact, it was.

matej_suchanek closed this task as Resolved.Jun 22 2017, 3:24 PM
matej_suchanek removed a project: TestMe.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL