Page MenuHomePhabricator

CodeEditor doesn't get along with MediaWiki:Gadget-wikEd.js
Closed, ResolvedPublic

Description

If WikEd is enabled when the .js page loads, there is no edit box. Disabling WikEd brings up the edit box. Disabling CodeEditor makes the box go away and it won't return without reloading the page. Code editor should disable and remove WikEd before loading the page.


Version: unspecified
Severity: major

Details

Reference
bz53914

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:01 AM
bzimport added a project: CodeEditor.
bzimport set Reference to bz53914.
bzimport added a subscriber: Unknown Object (MLST).

That is a problem of wikEd and should be fixed on en.wp. WikEd can check for contentmodel/contentformat and not loaded or so.

(In reply to comment #1)

That is a problem of wikEd and should be fixed on en.wp. WikEd can check for
contentmodel/contentformat and not loaded or so.

What does wikEd have to do with the second part of the problem? Disabling CodeEditor makes the box go away and it won't return without reloading the page.

I have made wikEd compatible with CodeEditor in the current version (0.9.119c). wikEd will not load if the CodeEditor is turned on during page load.

As long as the CodeEditor is turned off during page load, both can actually co-exist - just disable one before enabling the other.

Will test and mark as WORKSFORME as is appropriate. Just hoping I'll still be able to use wikEd's regex search and replace on .js and .css pages.

wikEd and wikEd's syntax highlighting are turned off by default on .js pages because the syntax highlighting eats tabs. So be careful...

Which part of this report should be fixed in the CodeEditor codebase?
The loading order?

For wikEd compatibility, everything would be fine without any changes. Unfortunately, there is Bug 62250...

Closing, because taken care of, and remainder has separate ticket.