Page MenuHomePhabricator

Quote cut at the right margin in spanish article‏
Closed, ResolvedPublic

Description

Author: a455304

Description:
In this article

https://es.wikipedia.org/wiki/Testigos_de_Jehov%C3%A1

At code

{{cita|Los Testigos de

it is cut at the right margin. Capture:

http://oi39.tinypic.com/2l8esnq.jpg

Any feedback about the cause?


Version: unspecified
Severity: normal

Details

Reference
bz53944

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:03 AM
bzimport set Reference to bz53944.
bzimport added a subscriber: Unknown Object (MLST).

Details from the email thread:

  • [[es:Template:cita]] applies a 'margin' in style element to that particular <blockquote>
  • MobileFrontend CSS applies a 'width: 90%' to all <blockquote>s
  • combination of these two ends up making the text spill offscreen because the specified margins are larger than the remaining 10% of the document width.

Recommended course of action:

  • tweak the box model along with the width in the MobileFrontend CSS
  • OR alternately... switch the 'width' there to a margin, which will get overridden by the style attribute.

I think styling blockquotes with margins (rather than width) makes the most sense, especially since the default user-agent styling of blockquotes is via margins. Right now the mobile styling of blockquotes is kind of a mess. First we override the user-agent styling by setting margins to 0, then we apply both a 90% width and a mix of padding and margins (margin to the top, padding to the left and bottom). Doing margin only would be much cleaner.

Change 84450 had a related patch set uploaded by Jdlrobson:
Fix blockquote styling

https://gerrit.wikimedia.org/r/84450

Change 84450 merged by jenkins-bot:
Fix blockquote styling

https://gerrit.wikimedia.org/r/84450

a455304 wrote:

The same file from tinypic which will be deleted

Attached:

Bug-53944-Wikipedia-mobile.jpg (758×471 px, 146 KB)