Page MenuHomePhabricator
Create Task
Maniphest T56007

"reverted"-type notifications should be based on the actual page content
Closed, ResolvedPublic
Actions

Description

my "revert"-type notification

The Echo extensions sends notifications of type "reverted" without checking if the edit was an actual revert: in https://en.wikipedia.org/w/index.php?diff=572391117 the IP added a single line return but preserved the original "undo" summary, and that triggered a notification to my account.

Instead, this check should be based on the actual page content. This could also work with non-mw rollback tools (Twinkle, etc.)

See Also:
T58574: Rollback notification doesn't check if it was a null revert
T154637: Notify users when manually reverting to an older revision

Attached:

notif.png (70×451 px, 6 KB)

Details

Reference
bz54007

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:07 AM
• bzimport added a project: Notifications.
• bzimport set Reference to bz54007.
• bzimport added a subscriber: Unknown Object (MLST).
Ricordisamoa created this task.Sep 11 2013, 1:47 AM
Ricordisamoa added a comment.Sep 13 2013, 11:45 PM

see also https://en.wikipedia.org/w/index.php?oldid=572814015#A_bit_concerned_about_revert_notifications.

Ricordisamoa added a comment.Sep 13 2013, 11:53 PM

oops, correct URL: https://en.wikipedia.org/w/index.php?oldid=572814015#A_bit_concerned_about_revert_notifications%2E

He7d3r added a comment.Sep 23 2013, 10:45 AM

Confirmed on Portuguese Wikipedia:

  1. Go to

https://pt.wikipedia.org/wiki/WP:Página_de_testes/4?action=edit

  1. Make an edit:

https://pt.wikipedia.org/w/index.php?diff=36963044

  1. Open the diff using another account and click on "undo":

https://pt.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:P%C3%A1gina_de_testes/4&action=edit&undoafter=36960091&undo=36963044

  1. This will fill in the summary with the default revert summary, which in Portuguese is as follows:

"Desfeita a edição 36963044 de [[Special:Contribs/Reverta-me|Reverta-me]]"

  1. Restore the content which would be deleted by the reversion, and add some extra, and save:

https://pt.wikipedia.org/w/index.php?diff=36963048

  1. Go to the first account and notice the reversion notification pointing to

https://pt.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:P%C3%A1gina_de_testes/4&oldid=36963048&diff=prev

On the other hand,

  1. Make the same edit again and open the diff with another account:

https://pt.wikipedia.org/w/index.php?diff=36963052

  1. Click on "undo" and copy the default revert summary
  2. Click on "edit" (i.e., discard the reversion and just start a new edit)
  3. Paste the revert summary in the summary field:

"Desfeita a edição 36963052 de [[Special:Contribs/Reverta-me|Reverta-me]]"

  1. Remove the content added by the first account from the edit box (i.e., make a "manual" reversion) and save:

https://pt.wikipedia.org/w/index.php?diff=36963078

  1. The first account will NOT be notified of this reversion
• Spage added a comment.Sep 23 2013, 8:49 PM

Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/249

Ricordisamoa added a comment.Aug 9 2014, 5:23 AM

Any updates on this?

• werdna unsubscribed.Dec 10 2014, 5:02 PM
matthiasmullie triaged this task as Medium priority.Dec 11 2014, 11:37 AM
matthiasmullie added a project: Collaboration-Team-Triage.
matthiasmullie set Security to None.
• Mattflaschen-WMF mentioned this in T85728: Revert notifications in Echo when "non-edit" contributions are in page history.Jan 9 2015, 5:07 AM
Technical13 subscribed.Jan 9 2015, 2:10 PM
Liuxinyu970226 subscribed.Jan 24 2015, 2:43 AM
EBernhardson merged a task: T59474: Very easy to spoof revert notification.Feb 27 2015, 6:53 PM
EBernhardson added subscribers: EBernhardson, • MZMcBride.
Ricordisamoa awarded a token.Feb 28 2015, 2:41 AM
Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 9:14 AM
• Mattflaschen-WMF added a subtask: T152434: Add method to Revision to check if it was a Revert, and whether an edit was Reverted.Aug 23 2017, 9:27 PM
Aklapper removed a project: Collaboration-Team-Triage.Oct 12 2019, 4:11 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 12 2019, 4:11 AM
Ostrzyciel closed subtask T152434: Add method to Revision to check if it was a Revert, and whether an edit was Reverted as Resolved.Sep 15 2020, 7:30 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 7:05 PM
matej_suchanek added a subtask: T277649: Update Echo for the EditResult revert detection improvements.Jun 17 2021, 5:25 PM
• ppelberg closed subtask T277649: Update Echo for the EditResult revert detection improvements as Resolved.Jul 20 2021, 11:52 PM
matej_suchanek updated the task description. (Show Details)Aug 24 2021, 10:07 AM
matej_suchanek removed a subscriber: • wikibugs-l-list.
Ostrzyciel closed this task as Resolved.Sep 3 2021, 11:40 AM
Ostrzyciel claimed this task.
Ostrzyciel subscribed.

This was resolved as part of introducing the EditResult class. Undos don't trigger a notification if they are not the result of a "clean" 3-way merge.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL