Author: wp.nirakka
Description:
The tooltips (on mouseover) for MediaWiki shortcuts omit the necessary shift key. For instance, the history button claims shortcut [alt-h] (instead of [alt-shift-h]). This issue occurs in Iceweasel 20.0 on Debian Wheezy.
Version: 1.22.0
Severity: minor
OS: Linux
Platform: PC
URL: http://en.wikipedia.org/
With Firefox 23.0.1 on Fedora19 on en.wikipedia.org, I get the correct keyboard shortcuts when hovering the mouse over "Read | Edit source | Edit beta | View history".
The HTML source code of the page says
<a accesskey="h" title="Past versions of this page [alt-shift-h]" href="/w/index.php?title=Berlin&action=history">
What makes you think that this is a Wikimedia and not a Iceweasel problem?
wp.nirakka wrote:
The problem does not occur on other MediaWiki installations, e. g. http://wiki.bnc4free.com/index.php/Main_Page shows the correct shortcuts in Iceweasel.
That site is running an older version of MediaWiki (1.18).
The shortcuts shown in the tooltips are browser-dependent. "alt-shift" is meant for Firefox 2.x and later, "alt" is the default when browser can't be detected.
It seems like something makes Seamonkey 20 undetectable for MediaWiki 1.22 alpha (the version Wikipedias run).
Well, jQuery.client correctly detects Iceweasel as iceweasel [1] (in 1.18 Iceweasel was detected as firefox), but mediawiki.util doesn't have any rule for iceweasel (only for firefox [2]), so the displayed prefix falls back to "alt-".
Alternativly, fix bug 37239 to reduce the mess that's necessary to find the correct prefix.
[1] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/554a5d04433207c6386d8c54281ac4e58b220a47/tests%2Fqunit%2Fsuites%2Fresources%2Fjquery%2Fjquery.client.test.js#L193
[2] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/554a5d04433207c6386d8c54281ac4e58b220a47/resources%2Fmediawiki%2Fmediawiki.util.js#L56
Hm, okay, that sounds simple enough – thanks for the analysis, Michael. You should get [[mw:developer access]] and start fixing those bugs yourself :)
Using the accessKeyLabel property per bug 37239 would be a little annoying to implement (particularly because Firefox and friends, still the only browsers supporting it, use a different format than MediaWiki – Alt+Shift+X instead of alt-shift-x) and not really worth it (because, again, no other browsers support this).
I'll submit a patch in a second – I'd appreciate if you could test it.
Change 84225 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.util: Detect Iceweasel for accesskeys
Marking as fixed, it'd be nice if one of you could verify that the patch does indeed fix the issue :)
wp.nirakka wrote:
If the change should be visible immediately, the patch doesn't work. I still get [alt-h] for history on English wikipedia. :/
No, it will only get deployed to Wikipedias and other sites on September 26. The deployment calendar is available at https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap