Page MenuHomePhabricator

Files/images should be fetched in batch by parser, not one at a time
Open, MediumPublic

Description

File objects are looked up in the Parser one at a time as they're encountered. This isn't too bad on Wikimedia sites because all the file repositories are on the local network, but for third-party sites running with InstantCommons on, pages with lots of images can take a *long* time to render.

Parser::fetchFileNoRegister() does an individual wfFindFile() call. It could be *much* more efficient to call RepoGroup::findFiles() in batches; for InstantCommons images this would allow for batching the API requests, reducing the round-trip time significantly.


Version: 1.22.0
Severity: normal

Details

Reference
bz54033