Page MenuHomePhabricator

[Regression] Placeholder for search input is black instead of gray
Closed, ResolvedPublic

Description

[1] added
color: black
to
div#simpleSearch input#searchInput,
which has a higher specifity than the selector with
color: #999
for the placeholder in [2]ff.

[1] https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/a9881e87d456305cc4ddc2fdf35cd346283f3072
[2] https://git.wikimedia.org/blob/mediawiki%2Fcore.git/554a5d04433207c6386d8c54281ac4e58b220a47/skins%2Fvector%2Fscreen.css#L407


Version: 1.22.0
Severity: trivial

Details

Reference
bz54069

Event Timeline

Ugh, yes, my bad. Thanks for spotting. I5fe0543e fixes this among other issues.

Also, this only affects browsers without native placeholder support: very old Firefoxes and Operas and IE<10. http://caniuse.com/#feat=input-placeholder

(In reply to comment #1)

Also, this only affects browsers without native placeholder support

I (have to) use an old Firefox, but it is Firefox 10, which already has placeholder support, and the color changed to black there.

Change 82100 had a related patch set uploaded by Bartosz Dziewoński:
Rewrite rendering of Vector simple search

https://gerrit.wikimedia.org/r/82100

(In reply to comment #2)

(In reply to comment #1)

Also, this only affects browsers without native placeholder support

I (have to) use an old Firefox, but it is Firefox 10, which already has
placeholder support, and the color changed to black there.

Indeed, and that makes perfect sense.

Selector "div#simpleSearch input#searchInput" overrides "div#simpleSearch input.placeholder" (the emulated placeholder), but also "div#simpleSearch input::-webkit-input-placeholder" and "div#simpleSearch input:-moz-placeholder". Both these selectors have the same specificity (element, id, element, class/pseudo-class)

Change 92201 had a related patch set uploaded by Bartosz Dziewoński:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92201

I submitted a separate patch for this since the big one probably isn't getting merged into 1.22. I'll make sure to backport it. Sorry about the mess.

Change 92774 had a related patch set uploaded by Krinkle:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92774

Change 92201 merged by jenkins-bot:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92201

Change 92774 merged by jenkins-bot:
vector: Restore gray search input placeholder

https://gerrit.wikimedia.org/r/92774

Fixed and backported. The fix should be included in next release candidate.