Page MenuHomePhabricator

Special:Contributions parameters are not applied to feed link (action=feedcontributions)
Closed, ResolvedPublic

Description

In the example URL, which you get by selecting a namespace from the standard Special:Contributions page for a user, the link to feed URL is wrong both in sidebar and in the metadata (used e.g. by the browser feed icon now moved to extensions like https://addons.mozilla.org/en-us/firefox/addon/rss-icon/ ):

<link rel="alternate" type="application/atom+xml" title="Feed Atom per &quot;Special:Contributions&quot;" href="/w/api.php?action=feedcontributions&amp;user=Nemo+bis&amp;feedformat=atom" />

<li id="feedlinks"><a href="/w/api.php?action=feedcontributions&amp;user=Nemo+bis&amp;feedformat=atom" id="feed-atom" rel="alternate" type="application/atom+xml" class="feedlink" title="Feed Atom per questa pagina">Atom</a></li>

action=feedcontributions is documented only on https://meta.wikimedia.org/w/api.php : namespace, year, month, tagfilter, deletedonly, toponly are available but not linked.


Version: 1.22.0
Severity: normal
URL: https://meta.wikimedia.org/w/index.php?limit=50&tagfilter=&title=Special%3AContributions&contribs=user&target=Nemo+bis&namespace=8&tagfilter=&year=2013&month=-1

Details

Reference
bz54093

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM
bzimport set Reference to bz54093.
bzimport added a subscriber: Unknown Object (MLST).

This bug appears to relate to the output of Special:Contributions, and doesn't seem to have anything to do with the API beyond that the complaint is about the links *to* the API that are being generated. Reassigning accordingly.

(In reply to comment #1)

This bug appears to relate to the output of Special:Contributions, and
doesn't
seem to have anything to do with the API beyond that the complaint is about
the
links *to* the API that are being generated. Reassigning accordingly.

We don't have a "feeds" component but "API" is in practice a superset of it (even though some feeds are just an index.php action). "Special pages" is such a broad component... and then this could also be History or Recent changes component, as Contributions are just a filter for that data.
Anyway, doesn't matter that much. :)

Also see http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines - if "Bug 54093" was "Bug: 54093" it would have triggered an automated comment here.

Change 108287 had a related patch set uploaded by Brian Wolff:
Special:Contributions: add all params to feed URL

https://gerrit.wikimedia.org/r/108287

Change 108287 merged by jenkins-bot:
Special:Contributions: add all params to feed URL

https://gerrit.wikimedia.org/r/108287

(In reply to comment #5)

Change 108287 had a related patch set uploaded by Brian Wolff:
Special:Contributions: add all params to feed URL

https://gerrit.wikimedia.org/r/108287

This was not me, gerrit bot lies...

Anyhow, MrBlueSky's patch is merged, so fixed.

Change 110499 had a related patch set uploaded by Pawanseerwani:
textMigration.php : Migration of text from archive table to text table

https://gerrit.wikimedia.org/r/110499

pawanseerwani+bugzilla wrote:

I accidentally mistyped the Bug number in my patch to 54093. So kindly ignore the previous comment. Sincere Apologies.