Page MenuHomePhabricator

Make RedisConnectionPool & RedisBagOStuff compatible with HHVM's Redis extension
Closed, ResolvedPublic

Description

MediaWiki's Redis integration currently requires the phpredis extension, which is not available for HHVM. HHVM 2.1.0 includes a pure-PHP Redis extension (see /hphp/system/php/redis, added in https://github.com/facebook/hiphop-php/commit/2811e9da). We should attempt to make MediaWiki compatible with both client libraries.


Version: 1.22.0
Severity: enhancement
URL: https://github.com/facebook/hiphop-php/commit/2811e9da940bb040bd82b2c7d91ff27830e1af32

Details

Reference
bz54158

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:49 AM
bzimport set Reference to bz54158.
bzimport added a subscriber: Unknown Object (MLST).

Change 85003 had a related patch set uploaded by Ori.livneh:
Allow RedisConnectionPool to be used with HHVM's Redis library

https://gerrit.wikimedia.org/r/85003

Change 85003 merged by jenkins-bot:
Allow RedisConnectionPool to be used with HHVM's Redis library

https://gerrit.wikimedia.org/r/85003

We should have unit tests in core for these classes, but that's a separate bug.

[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]