Page MenuHomePhabricator

Puppet files in Mediawiki-Vagrant should be re-usable outside of vagrant
Closed, ResolvedPublic

Description

Currently it has a few specific things that are run indiscriminately (like loading the kernel modules for vbox, etc) that don't make sense in other environments when it is run (Labs, or my new laptop (if I get one) where I plan on running the puppet files locally). Perhaps having them conditionally check if they are running on vbox before loading those?


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=59864
https://bugzilla.wikimedia.org/show_bug.cgi?id=51858

Details

Reference
bz54160

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:49 AM
bzimport set Reference to bz54160.

Change 84431 had a related patch set uploaded by Ori.livneh:
Box Virtualbox-specific configs in 'virtualbox' module

https://gerrit.wikimedia.org/r/84431

Change 84431 merged by jenkins-bot:
Box Virtualbox-specific configs in 'virtualbox' module

https://gerrit.wikimedia.org/r/84431

Yuvi, can we close this now, or are there additional requirements?

I'm checking, by running it outside of vbox (in Labs).

So far I've run into issues with the puppet files assuming that a 'vagrant' user exists. I'm also not sure if the apt-cache stuff should be used outside of virtualbox.

So, the only two errors I get when running this in labs is:

err: Removing mount volatile: /var/lib/puppet/volatile does not exist or is not a directory

and

err: Removing mount software: /etc/puppet/software does not exist or is not a directory

Possibly caused by facter conflicts?

It works otherwise.

I'm going to mark this as resolved since MediaWiki-Vagrant is usable in labs.

There are definitely still "Vagrantisms" in the puppet roles that can be hunted down and removed as we migrate more things to use hiera variables and the "environment" switch. I don't think this bug represents those potential concerns well however. Specific bug reports (and patches!) would be welcome.