Port wmerrors / php-fatal-error.html to HHVM
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ori
	Sep 16 2013, 9:33 AM

Description

I'm not sure how much of wmerrors need to be ported. HHVM appears to enhance PHP's error reporting capabilities in various (alas, mostly undocumented) ways, so perhaps some of the fancy footwork in wmerrors won't need to be ported. But at minimum, php-fatal-error.html should work.

See onFatalError, onUnhandledException in hphp/runtime/base/execution-context.cpp

https://github.com/facebook/hiphop-php/blob/4eb05b745fd3018a6d9e51464cae06a4465ee142/hphp/runtime/base/execution-context.cpp

Version: wmf-deployment
Severity: enhancement

Details

Reference: bz54163

Related Objects

Mentioned In: T187147: Port mediawiki/php/wmerrors to PHP7 and deploy
T89169: Log php fatals with full backtraces again (fatal.log on fluorine)

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:49 AM

• bzimport added a project: WMF-General-or-Unknown.

• bzimport set Reference to bz54163.

ori created this task.Sep 16 2013, 9:33 AM

Retitling based on: https://github.com/facebook/hiphop-php/commit/bad8a99b4ab6bd606481aea320de902878e7378e

[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]

Looks like in HHVM we don't need to code our own extension to achieve both of wmerrors goals:

Logging stacktraces is configurable, e.g. https://gerrit.wikimedia.org/r/120162
Fancy error pages are doable by pointing ErrorDocument500 to a PHP file that uses error_get_last() to display the needed information.

Ping me when we will have a Puppet module for production and I'll help with configuring this.

https://gerrit.wikimedia.org/r/#/c/120180/

Max, feel like assigning this to yourself?

Is there anything left to assign?:)

bd808 mentioned this in T89169: Log php fatals with full backtraces again (fatal.log on fluorine).Apr 10 2015, 6:50 PM

Legoktm mentioned this in T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.Feb 13 2018, 3:54 AM

Legoktm added a project: php-wmerrors.May 21 2019, 8:05 AM

Legoktm removed a project: WMF-General-or-Unknown.

Port wmerrors / php-fatal-error.html to HHVMClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Port wmerrors / php-fatal-error.html to HHVM
Closed, ResolvedPublic
Actions