Page MenuHomePhabricator

Make sure LuaSandbox works in hiphop/hhvm
Closed, ResolvedPublic

Description

Sample HHVM extension: https://github.com/hiphop-php/hello-world


Version: unspecified
Severity: enhancement

Details

Reference
bz54190

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:52 AM
bzimport added a project: Scribunto.
bzimport set Reference to bz54190.

(In reply to comment #0)

Sample HHVM extension: https://github.com/hiphop-php/hello-world

Link seems to be broken.

(In reply to comment #1)

(In reply to comment #0)

Sample HHVM extension: https://github.com/hiphop-php/hello-world

Link seems to be broken.

The hiphop-php account no longer has any public repositories for some reason, but I can vouch that this was indeed the proper link when I submitted the bug. The repository is still in Google's index: http://i.imgur.com/J3eoqFt.png

Whee...

$ hhvm -c ../../config.hdf phpunit.php
Uncaught exception: Could not open extension /usr/local/hhvm-modules/luasandbox.so: dlopen(/usr/local/hhvm-modules/luasandbox.so, 9): Symbol not found: _executor_globals

Referenced from: /usr/local/hhvm-modules/luasandbox.so
Expected in: flat namespace

in /usr/local/hhvm-modules/luasandbox.so

Chad, generic support for dynamically loadable extensions does not mean that HHVM suddenly supports the whole Zend extension API. It makes the work of porting the extension simpler, but it doesn't mean it no longer needs to be done.

[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]