Page MenuHomePhabricator
Create Task
Maniphest T56263

EntityViewTest does not properly inject dependencies
Closed, InvalidPublic
Actions

Description

EntityViewTest has a newEntityView method that calls a static function EntityView::newForEntityContent() which pull in objects from the WikibaseRepo "registry" and from global state.

newEntityView is used in a bunch of test cases.

Version: master
Severity: normal

Details

Reference
bz54263

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:56 AM
• bzimport added a project: MediaWiki-extensions-WikibaseRepository.
• bzimport set Reference to bz54263.
• bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Sep 18 2013, 8:50 AM
Lydia_Pintscher added a comment.Feb 26 2014, 11:43 AM

Let's put this as a fixme in the code. The whole thing needs to be rewritten anyway at which point this will no longer apply.

adrianheine added a comment.Mar 7 2014, 2:37 PM

EntityView::newForEntityContent() does not exist anymore.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL