Page MenuHomePhabricator
Create Task
Maniphest T56285

VisualEditor: Media items are inserted after selection and do not replace them
Closed, DeclinedPublic
Actions

Description

Author: renukaalurkar

Description:
1)Log into http://en.wikipedia.beta.wmflabs.org
2)Go to your user page
3)Click on Edit beta tab
4)Click on More
5)Click Media
6)Enter santa claus, select a image from the selection of images
7)Select the image(the image is displayed in light blue)
8)Again click on More, then Media and select another image.

Expected:The original/old image should be replaced by the new image.
Observed: The new image is added and the original image is also displayed.

Another observation: Also, suppose there are 4 images Image1, Image2, Image3, Image4 one below the other. If Image2 is selected and I try to replace it with a new image, the new image appears in the place of Image3(instead of Image2).

Observed on Firefox and Chrome.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51033

Details

Reference
bz54285

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:58 AM
• bzimport added a project: VisualEditor-EditingTools.
• bzimport set Reference to bz54285.
• bzimport created this task.Sep 18 2013, 6:55 PM
Thryduulf added a comment.Oct 1 2013, 7:53 PM

I can confirm this is the current behaviour, and that both points are due to the same reason: new images are inserted immediately after a selected image.

However I'm not sure that this behaviour is incorrect though as it is consistent with what happens when a user inserts media or a template with text selected (the template/media is inserted after the selection rather than overwriting it) - see bug 52460.

There is an open request for the media settings dialog to allow an image to be easily changed though (bug 51033), which I think is a better way to handle this.

Jdforrester-WMF added a comment.Oct 1 2013, 7:58 PM

Yes, confirming that this is intentional; closing as "WONTFIX". I agree that changing in line with bug 51033 would make more sense.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL