Page MenuHomePhabricator

VisualEditor: [Regression] Copy/paste handlers intercept non-surface copy/paste events, even after VE is closed
Closed, ResolvedPublic

Description

For example, you can't copy/paste in the edit summary box.


Version: unspecified
Severity: major

Details

Reference
bz54375

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:04 AM
bzimport set Reference to bz54375.

Pasting from an external source into the edit summary box works fine for me.

However, once a page has been loaded in VE you cannot copy any text on that page until you reload - even after you have closed VE.

To reproduce:

  1. Load any page in VisualEditor.
  2. Do any of i. Press the browser back button to exit VE ii. Cancel the edit iii. make an edit and then save the page
  3. Select any text anywhere on the page and copy it to the clipboard
  4. Try to paste that text anywhere (search box, URL bar, text editor, etc)

Expected behaviour: Selected text is copied and pasted
Actual behaviour: Selected text is not copied and pasted

Marking as a regression as this is new behaviour in the latest release (version "false")

Change 85204 had a related patch set uploaded by Esanders:
Only listen for copy/paste on documentNode and pasteTarget

https://gerrit.wikimedia.org/r/85204

Change 85204 merged by jenkins-bot:
Only listen for copy/paste on documentNode and pasteTarget

https://gerrit.wikimedia.org/r/85204

Change 85783 had a related patch set uploaded by Catrope:
Only listen for copy/paste on documentNode and pasteTarget

https://gerrit.wikimedia.org/r/85783

Change 85784 had a related patch set uploaded by Catrope:
Only listen for copy/paste on documentNode and pasteTarget

https://gerrit.wikimedia.org/r/85784

Change 85783 merged by jenkins-bot:
Only listen for copy/paste on documentNode and pasteTarget

https://gerrit.wikimedia.org/r/85783

Change 85784 merged by jenkins-bot:
Only listen for copy/paste on documentNode and pasteTarget

https://gerrit.wikimedia.org/r/85784