VisualEditor: Long lines in preformatted paragraphs should not wrap in VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Thryduulf
	Sep 20 2013, 4:27 PM

Description

When a pre-formatted paragraph with long lines is displayed in VE it word wraps. However it doesn't word-wrap in display mode (T2260), meaning that you have no idea that you need to add manual line breaks until after you have saved.

See https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox3&oldid=573792519#Section_number_three (rendered) and https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox3&oldid=573792519&veaction=edit&section=2 (in VE)

The word wrapping in VE is actually better than what happens in read mode, but the two should not be different. Fixing T2260 would be better, but as it's been open since 2004 adjusting VE to match the current behaviour seems more realistic :/

Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=260

Details

Reference: bz54381

	Subject	Repo	Branch	Lines +/-
	Do not wrap <pre> nodes	VisualEditor/VisualEditor	master	+2 -3

Customize query in gerrit

Related Objects

Mentioned In: rGVED71ceef7dbb6b: Do not wrap <pre> nodes
T2260: Vector: Handle <pre> overflow with a scrollbar or wrapping
Mentioned Here: T2260: Vector: Handle <pre> overflow with a scrollbar or wrapping
T40043: VisualEditor: Long preformatted nodes display content splitting words at exactly browser width, not word-wrapped

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:05 AM

• bzimport added a project: VisualEditor-MediaWiki.

• bzimport set Reference to bz54381.

Thryduulf created this task.Sep 20 2013, 4:27 PM

Alternatively we could fix this bug in MediaWiki…

Created attachment 17129
Preformatted text in Edit- word wrapping is present

Attached:

Created attachment 17130
Read - no word wrapping

Attached:

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:04 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 4:27 PM

Krinkle mentioned this in T2260: Vector: Handle <pre> overflow with a scrollbar or wrapping.Dec 2 2014, 4:42 AM

matmarex subscribed.Apr 19 2015, 8:25 PM

This comment was removed by matmarex.

We have pre.ve-ce-branchNode { white-space: pre-wrap; } added per T40043, because Chrome/Safari will otherwise also wrap the text, not just between words, but anywhere (this affects any <pre> inside a contenteditable="true" node). I did some searching and found https://bugs.webkit.org/show_bug.cgi?id=35935; it appears that we can set word-wrap: normal; to override this behavior.

We also need to remove overflow: hidden from the surface to get regular sane horizontal scrolling behavior. It doesn't seem to be necessary…

Change 205177 had a related patch set uploaded (by Bartosz Dziewoński):
Do not wrap <pre> nodes

https://gerrit.wikimedia.org/r/205177

gerritbot added a project: Patch-For-Review.Apr 19 2015, 8:46 PM

Esanders updated the task description. (Show Details)Apr 20 2015, 11:54 AM

Esanders set Security to None.

Jdforrester-WMF closed this task as Resolved.Apr 20 2015, 7:58 PM

Jdforrester-WMF assigned this task to matmarex.

Jdforrester-WMF edited projects, added VisualEditor 2014/15 Q4 blockers, WMF-deploy-2015-04-22_(1.26wmf3); removed Patch-For-Review.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.

Change 205177 merged by jenkins-bot:
Do not wrap <pre> nodes