Page MenuHomePhabricator

No continue button in IE 8 for UploadWizard
Closed, ResolvedPublic

Description

Steps to reproduce:
0) Use Internet Explorer 8

  1. Log In at Commons
  2. Go to https://commons.wikimedia.org/wiki/Special:UploadWizard
  3. Select a file to upload
  4. File uploads
  5. But there is no continue-button

Expected result:
Continue-button after the file successfully uploaded. I can confirm that the upload succeeded by inspecting [[Special:UploadStash]].

There are various reports. Some of them at [[:commons:COM:FORUM]], [[:commons:COM:UH]], [[:commons:COM:HD]]


Version: unspecified
Severity: major
OS: Windows XP
Platform: PC

Details

Reference
bz54392

Related Objects

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:05 AM
bzimport set Reference to bz54392.

(In reply to comment #1)
People have different wayes to express

"at I choose the file, the start uploading, then I see the minimalized photography. but there is no icony "Further" (or Go on - i don't know how it in English version but in Polish it is "Dalej")"

With "Further", it is clear that the "continue button" is missing. It's always hard to describe something that is missing.

Is it not sufficient that I could reproduce this issue and identified the cause?
https://github.com/wikimedia/mediawiki-extensions-UploadWizard/commit/325b5ce20e82d00594480f10f749379c3549a65e#L15R720

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind sais that function.prototype.bind does not exist in IE 8.

HD (this was just archived): https://commons.wikimedia.org/wiki/Commons:Help_desk/Archive/2013/09#Software_error.3F

Change 85324 had a related patch set uploaded by Rillke:
Replacing function.prototype.bind with jQuery.proxy

https://gerrit.wikimedia.org/r/85324

Thanks. I have reports of this bug from attempted WLM participants. I'll tell them not to use Internet Explorer, but this is quite problematic.

I am going to install a polyfill at Commons. Prototype already has an implementation of that: http://prototypejs.org/doc/latest/language/Function/prototype/bind/

This is also an issue for:

  • Chrome < 7
  • Opera < 11.60
  • Safari < 5.1.4

(In reply to comment #2)

Is it not sufficient that I could reproduce this issue and identified the
cause?

The identified cause wasn't mentioned in comment 0 but it is in comment 2.
Thanks for tracking that down!

(In reply to comment #7)

Fixed locally at Commons by adding a polyfill:
https://commons.wikimedia.org/wiki/MediaWiki:BindPolyfill.js

Thanks, I have reports from the same users that it now works with IE8.

Change 85324 merged by jenkins-bot:
Replacing Function.prototype.bind with anonymous function

https://gerrit.wikimedia.org/r/85324

Fixed in MASTER branch but not yet deployed to the cluster.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:21 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:21 AM