Page MenuHomePhabricator

TemplateData: Fix "PHP Notice: Trying to get property of non-object in TemplateDataBlob.php on line 385"
Closed, ResolvedPublic

Description

Notice: Trying to get property of non-object in …/extensions/TemplateData/TemplateDataBlob.php on line 385

$data->description->$langCode

"description" is not required to exist. Either it should be, or this line should check for it.


Version: unspecified
Severity: trivial

Details

Reference
bz54422

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:08 AM
bzimport added a project: TemplateData.
bzimport set Reference to bz54422.

It is normalised version and explicitly made optional. The save parser/validation and API reading handle it properly.

The html renderer forgets to check it.

Fixing..

Change 86002 had a related patch set uploaded by Krinkle:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86002

Change 86002 merged by jenkins-bot:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86002

Change 86045 had a related patch set uploaded by Krinkle:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86045

Change 86046 had a related patch set uploaded by Krinkle:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86046

Change 86046 abandoned by Krinkle:
Account for absence of template description in #getHtml

Reason:
Not worth backporting to wmf17 (fixes a hidden php notice and introduces a UI feature). We're rolling over to wmf18/wmf19 in less than < 20 hours.

https://gerrit.wikimedia.org/r/86046

Change 86045 merged by jenkins-bot:
Account for absence of template description in #getHtml

https://gerrit.wikimedia.org/r/86045